Issue in identifying holidays for region :ca when used in Rails application in production mode about holidays

[alexdunae]

Thanks for reporting this (so embarrassingly long ago). I've picked up work on the gem again and this definitely will be addressed.

:ca is included in us.rb because US holidays currently draw in the informal North American holidays, which apply to Canada, too. It's a bit of circular logic that definitely doesn't make any sense.

I'm clearing out the low-hanging fruit of definition updates before taking a proper look at these more substantial problems like these in the next few weeks (or sooner).

[alexdunae]

Also of note, d75aca8 will make the UnknownRegionError much less likely. It was way over-keen before.

[ppeble]

Small update, I am in the process of refactoring the codebase so that we don't have a giant single file that contains all of our logic. I'm hoping that one of two things happens during this process:

1. I figure out what is causing problems like this while refactoring
2. Once the codebase is split up it will be easier to diagnose problems like this.

[ppeble]

I've merged in v4.0.0, which is a large refactor. This is my next target since it is now the oldest bug that I have inherited.

[ppeble]

Okay! I spent some time looking at this and testing locally and as far as I can tell the core problem has been resolved. The code that handles loading of regions and definitions has changed significantly. I am going to go ahead and close out this issue. Please open a new issue if the problem (or a similar one) persists.

As an aside, once I work through the current crop of issues I am going to A) spend some time with internal refactoring for clarity and B) look at the north american informal holidays. As Alex mentioned it is a bit confusing currently.