NYSE - Incorrect date for Independence day? about holidays

[ppeble]

Hi Jason, thanks for reporting and sorry for the delay, I'll take a look at this on my train ride home this evening and report back with what I find. Then we can make a plan on how to proceed.

[ppeble]

Whoops, jumped the gun on the 'bug' designation. I thought I found something but it turns out that I needed to read further. Got too excited! 😄

The issue here is that this is considered an 'observed' holiday and as such is not automatically returned unless you explicitly pass in the :observed flag, like so:

d = Date.civil(2015, 7, 3)
Holidays.on(d, :nyse, :observed)

The def used the :observed key for this: https://github.com/holidays/holidays/blob/master/data/nyse.yaml#L35

I'm not sure how I feel about :observed not being on 'by default' but I think it can be open to interpretation. I'll have to think about it.

Either way, does this work for you?

[jasonirwin]

It certainly does, thanks for the clarification.