Support Japanese rokuyo about holidays

[ppeble]

Yeah, that sounds great. I'm not familiar with it at all (which is hardly surprising, I guess, since I'm in the US) but I'd love to take a look at the PR. I'll leave this issue open for discussion until the PR comes through.

I'm not entirely sure how I would want to handle something like this...the current standard is for the definition files to equate to regions or areas. This would be a new calendar type instead. I'm not against this plan, really, I just need to think about it and talk it over a bit once the PR is out there. I'll also think about this for the refactoring that I'm doing. There is nothing saying that we need to keep the current meaning of 'definition' files as they are today.

Thanks!

[johnnyshields]

@ptrimble just did a brief investigation of the definition file and seems it won't work for the above requirement. The way the file is structure it assumes holidays occur once a year, but for this the same value may occur ~70 times a year.

[johnnyshields]

Did a bit more investigation and determined that if you know the Chinese Lunar calendar date there's straightforward logic to calculate the Rokuyo day. (To know the Chinese Lunar new year you need to store some sort of lookup table such as in this gem: https://github.com/lanvige/chinese_lunar)

In short I think Chinese Lunar calendar and Rokuyo are probably better suited for a separate gem, not Holidays.

[ppeble]

Gotcha! Feel free to ping me if you would like support or reviews, I'd be happy to investigate. Now that we own this 'holidays' org it might make sense to bundle some things together. Who knows!

I'm going to go ahead and close this. Thanks again!