Comments (4)
Hm, that is interesting! Let me take a look at this and see how we can integrate Orthodox Easter. I completely agree that just having the Julian calendar Easter is not enough.
I might push it back a bit while I refactor the app...right now the Easter calculations are right in the main lib/holidays.rb file. I would like to split Easter calculations out. When I split them out it should be easier to specify the different types of Easter calculations.
For the yaml file I would appreciate opening a PR against your branch. That way we can take a look and offer feedback. Here are some instructions (let me know if I can make them more clear): https://github.com/alexdunae/holidays#how-to-contribute
from holidays.
My colleagues and me tried creating a fork of your project and creating a pull request with the changes we made. Unfortunately the system did not allow to publish/sync/upload the PR. Maybe it is due to our free accounts or we are missing some steps. Could you give us advice how to do it? We could send you the package by e-mail or you can get it from here: https://www.dropbox.com/s/wqpci1fptisqa4u/holidays-1.2.0.zip?dl=0
from holidays.
Hi @tyrmyk , hm, you should be able to open a PR with a regular free account on Github. Did you follow these instructions? https://help.github.com/articles/creating-a-pull-request/
from holidays.
I'm going to go ahead and close this issue since we have an open PR and I am (finally) on top of it. Sorry again to you and your colleagues for my absolutely dreadful response time. I feel awful.
For posterity here is the PR: #117
from holidays.
Related Issues (20)
- Get a list of all holidays possible for a given region
- Manage Belgium parent region HOT 1
- I have an issue with columbus day HOT 1
- Version Bump Request HOT 4
- Korea's new year get next year's new year
- Islamic holidays
- Día de los Muertos is not listed
- How to prevent stacked observed holidays HOT 1
- GB Substitute Days over Christmas and New Year HOT 1
- Liberation Day, Region NL
- Queen Elizabeth II passing Bank Holiday HOT 10
- Loading custom holidays clears all the provided definitions? HOT 1
- Strange behavoir with end_of_month HOT 2
- Feast of San Giusto for Trieste, Italy should be on 3rd November
- Shouldn't July 3, 2026 be "Independence Day (observed)" in the US? HOT 2
- Project updates HOT 10
- Hanukkah does not appear in list of holidays HOT 1
- Black Awareness Day is not listed for Brazil HOT 1
- Carnival 2024 Missing from Brazil Holidays Listing HOT 1
- Holidays.on returns results inconsistent with Holidays.between
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holidays.