Coder Social home page Coder Social logo

Add new region - Bulgaria about holidays HOT 4 CLOSED

holidays avatar holidays commented on July 24, 2024
Add new region - Bulgaria

from holidays.

Comments (4)

ppeble avatar ppeble commented on July 24, 2024

Hm, that is interesting! Let me take a look at this and see how we can integrate Orthodox Easter. I completely agree that just having the Julian calendar Easter is not enough.

I might push it back a bit while I refactor the app...right now the Easter calculations are right in the main lib/holidays.rb file. I would like to split Easter calculations out. When I split them out it should be easier to specify the different types of Easter calculations.

For the yaml file I would appreciate opening a PR against your branch. That way we can take a look and offer feedback. Here are some instructions (let me know if I can make them more clear): https://github.com/alexdunae/holidays#how-to-contribute

from holidays.

tyrmyk avatar tyrmyk commented on July 24, 2024

My colleagues and me tried creating a fork of your project and creating a pull request with the changes we made. Unfortunately the system did not allow to publish/sync/upload the PR. Maybe it is due to our free accounts or we are missing some steps. Could you give us advice how to do it? We could send you the package by e-mail or you can get it from here: https://www.dropbox.com/s/wqpci1fptisqa4u/holidays-1.2.0.zip?dl=0

from holidays.

ppeble avatar ppeble commented on July 24, 2024

Hi @tyrmyk , hm, you should be able to open a PR with a regular free account on Github. Did you follow these instructions? https://help.github.com/articles/creating-a-pull-request/

from holidays.

ppeble avatar ppeble commented on July 24, 2024

I'm going to go ahead and close this issue since we have an open PR and I am (finally) on top of it. Sorry again to you and your colleagues for my absolutely dreadful response time. I feel awful.

For posterity here is the PR: #117

from holidays.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.