Comments (8)
+1 to Rspec, it's the way to go and most gems are using it.
from holidays.
I am going to do this but I have to push it off. I'm basically performing a complete rewrite of this gem and I just can't bring myself to go back and redo all of the existing tests yet. I'll leave that for a future enhancement and I'll leave this issue open in the meantime.
from holidays.
Just want to say that I really really really want to switch. Finishing up my tests without rspec has been hell.
from holidays.
+1 to Rspec.
from holidays.
+1 from me too
from holidays.
I'm going to be the dissenting voice in this discussion and say that I think it would be better to keep the test suite as-is. While rspec's DSL is great and it has a lot of features, the simplicity and default "Rubyness" of Test-Unit is much easier to get my head around. Plus, converting the test suite would be a lot of extra work. I guess it comes down to a cost/benefit analysis -- are the features you rely on in rspec worth the pain of re-writing the entire suite?
from holidays.
Thanks for the feedback, everyone. I'm gonna leave this open for a bit but...I'm basically coming to terms with the fact that, as a new dad and someone with a fulltime job, I just don't think I'll ever truly have the bandwidth to do this entirely unnecessary change. And as @jonathanpike pointed out, what are we really gaining? Yes, I love rspec and I like it more than Test-Unit, but I don't love it so much so that I would be willing to spend nights re-writing already working tests. 😉
As I said I'll leave this open for more discussion but unless someone else is willing to step up and make the transition I don't think it's gonna happen.
from holidays.
Going to go ahead and close this. TestUnit is good for us! It has served us well. Unless a compelling PR comes in we won't be switching.
from holidays.
Related Issues (20)
- Get a list of all holidays possible for a given region
- Manage Belgium parent region HOT 1
- I have an issue with columbus day HOT 1
- Version Bump Request HOT 4
- Korea's new year get next year's new year
- Islamic holidays
- Día de los Muertos is not listed
- How to prevent stacked observed holidays HOT 1
- GB Substitute Days over Christmas and New Year HOT 1
- Liberation Day, Region NL
- Queen Elizabeth II passing Bank Holiday HOT 10
- Loading custom holidays clears all the provided definitions? HOT 1
- Strange behavoir with end_of_month HOT 2
- Feast of San Giusto for Trieste, Italy should be on 3rd November
- Shouldn't July 3, 2026 be "Independence Day (observed)" in the US? HOT 2
- Project updates HOT 10
- Hanukkah does not appear in list of holidays HOT 1
- Black Awareness Day is not listed for Brazil HOT 1
- Carnival 2024 Missing from Brazil Holidays Listing HOT 1
- Holidays.on returns results inconsistent with Holidays.between
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holidays.