hl7 / cql Goto Github PK

STU4B#131 recommends continuing to expand test cases in the specification. There was not time to expand the test cases prior to publication of this ballot cycle, so this issue is logged to track additional updates to the test cases to cover the rest of the specification as part of continued STU testing.

Issue/Question

Now(), Today() and TimeOfDay are supported operators in CQL: https://cql.hl7.org/02-authorsguide.html, but they are not included in the Antlr4 grammar.

IIUC, Antlr4 listners can only listen for the defined keywords in the grammar. In this case, how does a CQL implementation parse and evaluate an expression like Now() + 7 days?

Many tables that look ok on github (.adoc) do not render correctly on HL7 site (.html). For example, Table 2-B.
Compare
https://github.com/HL7/cql/blob/master/spec/2018May/02-authorsguide.adoc#parameters
and
https://cql.hl7.org/2018May/02-authorsguide.html#parameters

According to the thread CQL Execution the semantics of exists have changed. That change should be reflected in tests, because there is a test called ExistsListNull. Happy to create a PR, if I'm right here.

Add publication packages for:

info.cqframework.cql - base specification XSDs for ELM and ModelInfo
info.cqframework.cql.tests - CQL test cases

The discussion at the end of the Comparison Operators section is inconsistent with the description of Equivalent functionality in the Logical Specification and CQL Reference. Specifically, it says: "The equivalent operator is the same as equality, except that it returns true if both of the arguments are null, and false if one argument is null and the other is not:" But it should note that equivalence has looser semantics than strict equality for many types (e.g. Strings, Codes, Concepts, and Quantities).

In the Intersect logical spec, the expression is marked as descending from NaryExpression. However, the verbiage below refers to "both arguments" and "either argument", making it sound like Intersect is actually a BinaryExpression. Which is correct? Some other expressions like Union and Except also have the same issue; I'd be happy to put together a PR to align the language in all of them, once I know which way to edit!

Division should cancel units (just as multiplication multiplies them)

10.1 'cm' div -3.1 'cm should result in -3.0 '1'

https://github.com/HL7/cql/blob/master/tests/cql/CqlArithmeticFunctionsTest.xml#L829