hjiayz / quickjs_regex

quickjs_regex

quickjs libregexp

windows

install clang

set CC=clang

License: MIT OR Apache-2.0

quickjs_regex's Issues

`Regex` deallocates memory in Rust which was allocated by C

The struct Regex contains a Cow<'static, [u8]> which is initialized as Cow::Owned using a pointer allocated by C.

Cow::Owned(unsafe { Vec::from_raw_parts(byte_code_ptr, byte_code_len, byte_code_len) });

However, when a Cow::Owned is dropped, its memory is deallocated in Rust, which is undefined behavior if Rust is configured to use a different allocator than C.

[The pointer] must denote a block of memory currently allocated via this allocator
This is not immediately a problem, since Rust will use the System allocator by default, but it could result in UB if someone uses this crate in an application that override's Rust default allocator.

Fixing this would require implementing a new C API function lre_free. Note that the pointer returned by lre_compile is the field buf of an object of type DynBuf. This prevents us from reusing dbuf_free, since that requires an object of type DynBuf.