hirofa / spidermonkey_runtime Goto Github PK

• Fix clippy warnings
• Run clippy with -- -D warnings or maybe RUSTFLAGS: -D warnings

implement an API for the fetch function, implementing party should be able to pass a callback to resolvet the url and return a response object

https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API

https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

https://github.com/servo/servo/blob/854cc793861c31c395387a1197c40e840bc95826/components/script/fetch.rs

refactor methods, getter, setters to return a Result<JSVal, String> so we can throw errors from Proxy classes

If I understand correctly you call rust function from JS like:
esses.invoke_rust_op_sync("print", "this will be printed")
is it possible to invoke it like:
print("this will be printed")

Writing rust functions for JS is still pretty hard (not hard as writing it directly for mozjs):

fn reg_op(rt: &EsRuntimeWrapper) {
    rt.register_op(
        "my_rusty_op",
        Arc::new(|_rt, args: Vec<EsValueFacade>| {
            let a = args.get(0).unwrap().get_i32();
            let b = args.get(1).unwrap().get_i32();
            Ok(EsValueFacade::new_i32(a * b))
        }),
    );
}

My idea is that adding rusty code to JS should be as close as writing normal rust code and than just telling es_runtime to use that function (preferably even without special types, using Rusts types).

servo/mozjs#275

or just reference sagudevs repo

pass return_value: MutableHandleValue instead of returning JSVal

Log a message when a promise without a catch handler is rejected

Hi, first of all thanks for this nice simplification of the Spider Monkey interface.

Now I'm rather new to Rust and this library and I wanted to add a global function to "register" functions. These functions are saved in a map and called later. My code looks like this:

let rt = EsRuntimeBuilder::new().build();

let mut map = HashMap::new();

rt.add_global_sync_function("test", |args| {
  map.insert(args[0].get_string(), &args[1]);
  Ok(EsValueFacade::undefined())
});

This won't compile (Error message: (dyn es_runtime::esvaluefacade::EsValueConvertible + std::marker::Send + 'static) cannot be shared between threads safely).

I don't expect it to work like this but this was my only approach. I'd guess doing it like this will conflict with the GC as it doesn't know whether the arguments are still used.

Now my question is: Is there a proper way of saving a EsValueFacade in a map and being able to use it later which won't conflict with the GC and the Rust compiler?

https://doc.servo.org/mozjs/jsapi/fn.JS_FreezeObject.html
https://doc.servo.org/mozjs/jsapi/fn.JS_DeepFreezeObject.html

https://doc.servo.org/mozjs/jsapi/fn.SetModuleMetadataHook.html
setmoduleprivate , this adds a private obj to the module?
this is populated by populateImportMeta? set url

we want this so we can alter the moduleLoader to also have a url which imports the new module so we can support relative paths

url should allways be full path so loading /mod,mes from one module or the other can load a different module entirely, caching should be done by full path

currently there is a lot of error reporting done with the JSAPI method like so

unsafe {
    JS_ReportErrorASCII(cx, b"poof\0".as_ptr() as *const libc::c_char);
}

we need a pub fn report_error(err: &str); in es_utils.rs which does the above so the occurances in

• the rest of the code may be replaced with this:

es_utils::report_error(cx, "poof");

• the util should look something like this

// in es_utils.rs
pub fn report_error(cx: 8mut JSContext, err: &str) {
    let err_string = format!(b"{}\0", err);
    unsafe {
        JS_ReportErrorASCII(cx, err_string.as_str().as_ptr() as *const libc::c_char);
    }
}

• There is also a JS_ReportErrorUTF8 we may want to figure out if and when we need that

• the current report_es_ex() in es_utils.rs should be renamed to ```fetch_pending_exception()

• for at least
  • EsValueFacade
  • EsProxy
  • Proxy
  • EsRuntime(Builder)
  • SmRuntime
• later
  • jsapi_utils.rs
  • arrays.rs
  • functions.rs
  • modules.rs
  • objects.rs
  • promises.rs
  • rooting.rs

Now, as the base work is done, you can additional functionality to GitHub actions, here is list of my favorite:

• Automatic format
• Docs generation and publishing it to GitHub pages
• Annotations (clippy lints)
• Add cache to speed up rebuilding process

I have implemented them here, so just say which functionality do you want and I will make PR.

Move text from docs folder to Doc comments, so they appear with the rest of API docs.

implement an API to add features (objects) based on import events rather than just code

this is a modification to the current code loader which can return either code or an object (or null when a feature is installed by impl)

see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Dynamic_Imports

todo:

• test if this works by default in new mozjs with the current hooks,
• see if it works with different hooks,

the clippy workflow started giving errors about a 404 @

##[error]An action could not be found at the URI 'https://api.github.com/repos/actions-rs/clippy-check/tarball/annotations-fallback'

i updated this to v1 in cc59e11

it works now but the actions takes only 7m instead of the usual 12-14 minutes

i can only find examples about the v1 variant so my question is what is the annotations-fallback variant and should this still work or is my modification to v1 ok?

method to createa new instance of a proxy class

also needs reflection::new_instance(proxy_name: &str)

and esses.invoke_rust_op* methods in es

This repo uses 11 dependencies. Mozjs is logical, but others ...
From some dependencies only one function is used.

• typedArrays from and to Vecs

• EsValueFacade should get a TYPE enum and store it's value in a Any instead of the current ever growing if else if statements

• or something like a JSValCovertable for each type

• rewrite prmise stuff so we don't need es files anymore
• rewrite EsValueFacade
• add typedarrays stuff for EsValueFacade

or is that for ESsesLib only?

https://doc.servo.org/mozjs/?search=profiling