hinkey / netopeer Goto Github PK

What is the expected behaviour? What do you see instead?

--config and --url options are alternatives in edit-config operation. --config 
points to a local file while --url refers to a remote file. User expects that 
the content of both refered files has the same format, but it does not. --url 
file must contain <config> root element (defined in RFC 6241 sec 8.8.5.1), 
while --config file does not.

What steps will reproduce the problem?
1. Build using 'make rpm' or debhelper

What is the expected output? What do you see instead?
The wrong path to netopeer-agent is written to sshd_config, making the server 
unable to accept connections.  Example:

# NETCONF SSH Subsystem settings
Subsystem netconf /path/to/packager/destdir//usr/bin/netopeer-agent

What version of the product are you using? On what operating system?
Revision: 5d9d009eded0

Please provide any additional information below.
Patch attached.

[deleted issue]

Describe requested feature:

CLI stores commands into the history. But if the same command is invoked 
repeatedly, it is stored to the history file several times. It should be stored 
only once, when the same commands are used consecutively.

What steps will reproduce the problem?
1. send a "user-rpc make-toast" to the toaster

What is the expected output? What do you see instead?
The toaster should be toasting for the requested amount of time.
Unfortunately it toasts forever.


What version of the product are you using? On what operating system?
Branch : master 
Rev : c6bfde5ccbe7

Please provide any additional information below.
After some investigation I found the problem.

Function rpc_make_toast launch function make_toast in a new thread passing 
doneness as a parameter.
Unfortunately, doneness is a local parameter when the new thread uses it... it 
as been scratch by "something else".
The new thread will then sleep for an unpredictable amount of time.

declaring this local variable as "static" will make it exists for the whole 
execution time.

You will find here my proposed patch.

------------------------------------
@@ -226,7 +226,7 @@ nc_reply * rpc_make_toast (xmlNodePtr input[])

        struct nc_err * err;
        nc_reply * reply;
-       int doneness; 
+       static int doneness; 
        pthread_t tid;

        if (toasterDoneness == NULL) { /* doneness not specified, use default*/
------------------------------------

Regards.
Vincent

[deleted issue]

What steps will reproduce the problem?
1. Issue a get-schema rpc. 
<rpc message-id="m-0" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
<get-schema xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring">
<format>yang</format>
<identifier>ietf-netconf-acm</identifier>
<version>2012-02-22</version>
</get-schema>
</rpc>
2. Wait for result rpc


What is the expected output? What do you see instead?

Expected response is rpc-reply conforming to the ietf-netconf-monitoring, with 
namespace urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring.

Incorrect returned value was:

<?xml version="1.0" encoding="UTF-8"?>
<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="m-0">
  <data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">module "ietf-netconf-acm" {
  namespace "urn:ietf:params:xml:ns:yang:ietf-netconf-acm";
  prefix "nacm";
  ...

Which contains a data element with namespace 
urn:ietf:params:xml:ns:netconf:base:1.0.
The correct namespace should be 
urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring.



Build on master

Please provide any additional information below.

[deleted issue]

Describe requested feature:

After the installation, it would be helpful to have some standalone tool to set 
all neccessary things before the first use of Netopeer (mainly server). 
Especially correct initial NACM setting is a challenging thing and this tool 
could make user's life easier.

Describe requested feature:

prepare man pages for netopeer-* tools

[deleted issue]

As mention in toaster.yang the Toaster status should reflect the knob position.

----
leaf toasterStatus {
            type enumeration {
                enum up {
                  value 1;
                  description
                    "The toaster knob position is up.
                      No toast is being made now.";
                }
                enum down {
                  value 2;
                  description
                    "The toaster knob position is down.
                      Toast is being made now.";

                }
            }
----

This is not the case today as the toaster status is mapped on "status->enabled".

It should be mapped on "status->toasting".

I propose the following patch
------------------
--- a/server-sl/toaster/toaster.c
+++ b/server-sl/toaster/toaster.c
@@ -125,7 +125,7 @@ xmlDocPtr get_state_data (xmlDocPtr model, xmlDocPtr 
running, struct nc_err **er
        xmlSetNs(root, ns);
        xmlNewChild(root, ns, BAD_CAST "toasterManufacturer", BAD_CAST "CESNET, z.s.p.o.");
        xmlNewChild(root, ns, BAD_CAST "toasterModelNumber", BAD_CAST "toaster");
-       xmlNewChild(root, ns, BAD_CAST "toasterStatus", BAD_CAST 
(status->enabled ? "up" : "down" ));
+       xmlNewChild(root, ns, BAD_CAST "toasterStatus", BAD_CAST 
(status->toasting ? "down" : "up" ));

        return (state);
 }
-------------------

What version of the product are you using? On what operating system?
Branch : master
Rev : c6bfde5ccbe7

Best regards
Vincent

[deleted issue]

[deleted issue]

What steps will reproduce the problem?
The below two files are not exactly same.
1. netopeer/server/config/ietf-netconf-server.yin
2. http://www.netconfcentral.org/modulereport/ietf-netconf-server


What is the expected output? What do you see instead?
If netconf client uses standard yang file and triggers edit-config, it will 
fail in Netopeer (libnetconf) validation.

What version of the product are you using? On what operating system?
Version :
---------
libnetconf 0.8.0
netopeer 0.6.0

Operating System :
-------------------
Ubuntu 12.04.4 LTS

Please provide any additional information below.

What steps will reproduce the problem?
1. Send an invalid (syntax incorrect) XML configuration file, the first time 
edit one module like toaster, 

What is the expected output? What do you see instead?
Expected an error message ('Malformed message') to be returned to the client.
Instead, server accept the xml config and write to the datastore without check. 

netconf> edit-config running

  Type the edit configuration data (close editor by Ctrl-D):
<toaster xmlns="http://netconfcentral.org/ns/toaster">
<hello/>
</toaster >

  Result OK
netconf> get-config running

  Result:
<toaster xmlns="http://netconfcentral.org/ns/toaster">
    <hello/>
  </toaster><netopeer xmlns="urn:cesnet:tmc:netopeer:1.0">
    <modules>
      <module>
        <name>toaster</name>
        <enabled>true</enabled>
      </module>
    </modules>
</netopeer>

What version of the product are you using? On what operating system?
libnetconf--- commit b760b663
netopeer---   commit 3eb0a100fcaf

Please provide any additional information below.

patch to fix optional arguments, when short option is used

What steps will reproduce the problem?
1.an clean datastore file, datastore-server.xml
2.edit-config running with a user-defined config data within which has a 
"create" operation.

This is the config data I have input.
netconf> edit-config running

  Type the edit configuration data (close editor by Ctrl-D):

<netconf xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-server">
  <ssh>
    <call-home>
      <applications>
        <application nc:operation="create">
          <name>eric</name>
            <servers>
              <server>
                <address>192.168.168.8</address>
                <port>1113</port>
              </server>
            </servers>
        </application>
      </applications>
    </call-home>
  </ssh>
</netconf>
-----------------------------------------------------------
This is the expected output
<?xml version="1.0" encoding="UTF-8"?>
<datastores xmlns="urn:cesnet:tmc:datastores:file">
  <running lock="">
    <netconf xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-server">
      <ssh>
        <call-home>
          <applications>
            <application>
              <name>eric</name>
              <servers>
                <server>
                  <address>192.168.168.8</address>
                  <port>1113</port>
                </server>
              </servers>
            </application>
          </applications>
        </call-home>
      </ssh>
    </netconf>
  </running>
  <startup lock=""/>
  <candidate modified="false" lock=""/>
</datastores>
--------------------------------------------------------------
What do you see instead?
<?xml version="1.0" encoding="UTF-8"?>
<datastores xmlns="urn:cesnet:tmc:datastores:file">
  <running lock="">
    <netconf xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-server">
      <ssh>
        <call-home>
          <applications>
            <application xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-server">
              <name>eric</name>
              <servers>
                <server>
                  <address>10.68.168.8</address>
                  <port>1113</port>
                </server>
              </servers>
            </application>
          </applications>
        </call-home>
      </ssh>
      <ssh xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-server">
        <call-home>
          <applications/>
        </call-home>
      </ssh>
    </netconf>
  </running>
  <startup lock=""/>
  <candidate modified="false" lock=""/>
</datastores>
--------------------------------------------------------------
What version of the product are you using? On what operating system?
---I use commit 3eb0a100fcaf under ubuntu 12.04

Please provide any additional information below.
---when I use merger instead of create, there is no problems like above.

[deleted issue]

What steps will reproduce the problem?
1. Use ncclient and try edit config
2. netopeer-server segfaults
3. The same request works correctly when using netopeer-cli 

Crash Data:
netopeer-server[2355]: segfault at 2c ip b67a6d50 sp bfa9f200 error 4 in 
libaugeas.so.0.18.0[b67a0000+56000]

This might have something to do with the xml namespaces. 

1. The same request from netopeer-cli works correctly. 
The request as sent by netopeer-cli 

<?xml version="1.0" encoding="UTF-8"?>#012<rpc 
xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="7">#012  
<edit-config>#012    <target>#012      <running/>#012    </target>#012    
<config>#012      <system xmlns="urn:avaya:params:xml:ns:yang:ona100">#012      
  <status>#012          <device-status>green</device-status>#012        
</status>#012      </system>#012    </config>#012  </edit-config>#012</rpc>

2. The request sent by ncclient. This causes the crash 

 <?xml version="1.0" encoding="UTF-8"?>#012<nc:rpc xmlns:nc="urn:ietf:params:xml:ns:netconf:base:1.0" xmlns:ns1="urn:avaya:params:xml:ns:yang:ona100" message-id="urn:uuid:c9d007ea-d29c-11e4-87b8-080027ba1a92">#012  <nc:edit-config>#012    <nc:target>#012      <nc:candidate/>#012    </nc:target>#012    <config>#012      <ns1:system>#012        <ns1:status>#012          <ns1:device-status>green</ns1:device-status>#012        </ns1:status>#012      </ns1:system>#012    </config>#012  </nc:edit-config>#012</nc:rpc>

In commit FEATURE: agent-server communication over UNIX socket (e25c51ae) the 
function server_sessions_get_by_id was renamed to server_sessions_get_by_ncid. 
This was done only in the header file (server_operations.h).

Attached is a patch that renames all occurances of server_sessions_get_by_id to 
server_sessions_get_by_ncid

cheers
Tobi

I just saw this line in commit 42d8acbba52:

+   if (timezone == (char*)9 || (timezone[0] != '+' && timezone[0] != '-') || 
strlen(timezone) != 6) {

I guess the 9 should be a 0, or better one should use NULL here.

Attached the patch to fix this.

[deleted issue]

From debug output of mod_netconf during RPC call:

[Sat Oct 18 23:36:37 2014] [error] NC_VERB_DEBUG: Writing message (session 
15387): <?xml version="1.0" encoding="UTF-8"?>\n<rpc 
xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="17">\n  
<set-current-datetime xmlns="urn:ietf:params:xml:ns:yang:ietf-system">\n    
<current-datetime>20:00</current-datetime>\n  </set-current-datetime>\n</rpc>\n
[Sat Oct 18 23:36:38 2014] [error] NC_VERB_DEBUG: Received message (session 
15387): <?xml version="1.0" encoding="UTF-8"?>\n<rpc-reply 
xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="17">\n  
<rpc-error>\n    <error-type>application</error-type>\n    
<error-tag>operation-failed</error-tag>\n    
<error-severity>error</error-severity>\n    <error-message>agent-server 
communication failed.</error-message>\n  </rpc-error>\n</rpc-reply>\n

From /var/log/messages:
Oct 18 23:36:37 netopeer-gui netopeer-server[11434]: Calling 
set-current-datetime RPC function
Oct 18 23:36:38 netopeer-gui kernel: netopeer-server[11434]: segfault at 9 ip 
00007fdd1934a72b sp 00007fff15b70130 error 4 in cfgsystem.so[7fdd19347000+d000]
Oct 18 23:36:38 netopeer-gui netopeer-agent[15387]: comm_operation: 
communication failed, response mismatch - sending 5, but received 0.