hiimdoublej / django-json-ld Goto Github PK

Hey @hiimdoublej! I think last PR didn't went through the regular GH Actions process so the package didn't got updated on PyPI. You can check it here.

Can you please manually do the release? Thanks!

Following the readme:
https://github.com/hiimdoublej/django-json-ld#class-based-view-example

There is a line:
structured_data["event"] = get_next_event()

Should I import get_next_event from some library? Could not find anything in google

Hi,

I need queryset from get_queryset to construct the structured data.

The current implementation calls first get_structured_data() then get_queryset(). Is there a way to change this behavior.

One option would be to include get_structured_data's logic in get_queryset().

Kind regards,

H.KIZIL

If you try to use this library on a project with Django>=4.0, and InvalidTemplateLibrary get raised because of this deprecation.

django.template.library.InvalidTemplateLibrary: Invalid template library specified. ImportError raised when trying to load 'django_json_ld.templatetags.json_ld': cannot import name 'force_text' from 'django.utils.encoding'

From Django 3.0, the above deprecation warning was added:

The smart_text() and force_text() aliases (since Django 2.0) of smart_str() and force_str() are deprecated. Ignore this deprecation if your code supports Python 2 as the behavior of smart_str() and force_str() is different there.

Now Python 2 ended its life cycle and those were just aliases from Django 2.0, it's safe to change that import.

I'll submit another PR soon.

Hello again @hiimdoublej,

Currently when, for example, I use {% render_json_ld sd %} in base.html and sd is empty or non-existant, django will render:

<script type="application/ld+json">""</script>

Lets call that option A.

I'm wondering if that's the best default behaviour or if we should do something else. Two alternative ideas come to mind:

B. Output nothing, so no script tags are printed.

C. Output a schema.org Thing with the current page URL, something like:

<script type="application/ld+json">
{
   "@context":"https://schema.org"
   "@type":"Thing",
   "url":"http://example.org/",
}
</script>

We can also make this behaviour user configurable.

What are your thoughts?

I already install and add this package in install app Please suggest to use this django_json_ld I am facing error django_json_ld' is not a registered tag library.

Currently this library is not Python 3.10 compatible. This is due to the existing import on utils.py:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

I'll submit a PR soon fixing this.