Put C++ class definition in header files about simsopt

[florianwechsung]

What do we gain from splitting this? A downside of this splitting is a fairly significant code duplication between hpp and cpp files.

[mbkumar]

Why do you think there will be a large code duplication? As far as advantages of splitting, here is one article I can think of. Another advantage is it would make it easier for future developers/co-developers to identify the class interface easily.

[florianwechsung]

Many of the function in surface.cpp and curve.cpp are just a single line of code. Wouldn't having the declaration in a separate file means duplicating the function signature, which makes up most of the code in those files?

[mbkumar]

Those could be inlined meaning they will be part of class definition. So they move to header files. The larger methods remain in cpp files. Bharat Medasani Engineer Princeton Plasma Physics Lab (PPPL)

…

On Thu, Apr 8, 2021 at 1:39 PM Florian Wechsung ***@***.***> wrote: Many of the function in surface.cpp and curve.cpp are just a single line of code. Wouldn't having the declaration in a separate file means duplicating the function signature, which makes up most of the code in those files? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA62VEAPMIEE7JN2SPJPSDTTHXS3JANCNFSM42TISVXA> .

[mbkumar]

Actually, all the methods are inlined now. Typically short methods are inlined and bigger methods are implemented out of class definition. Bharat Medasani Engineer Princeton Plasma Physics Lab (PPPL)

…

On Thu, Apr 8, 2021 at 1:40 PM Bharat Medasani ***@***.***> wrote: Those could be inlined meaning they will be part of class definition. So they move to header files. The larger methods remain in cpp files. Bharat Medasani Engineer Princeton Plasma Physics Lab (PPPL) On Thu, Apr 8, 2021 at 1:39 PM Florian Wechsung ***@***.***> wrote: > Many of the function in surface.cpp and curve.cpp are just a single line > of code. Wouldn't having the declaration in a separate file means > duplicating the function signature, which makes up most of the code in > those files? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#41 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA62VEAPMIEE7JN2SPJPSDTTHXS3JANCNFSM42TISVXA> > . >

[florianwechsung]

I have made this separation in the BiotSavart code now. When I have some extra time I'll make similar changes to the surface and coil classes.

[mbkumar]

Cool. Thanks! Bharat Medasani Engineer Princeton Plasma Physics Lab (PPPL)

…

On Mon, Apr 12, 2021 at 11:01 AM Florian Wechsung ***@***.***> wrote: I have made this separation in the BiotSavart code now. When I have some extra time I'll make similar changes to the surface and coil classes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA62VEAM6YY5C6X2R66ZCLDTIMDM5ANCNFSM42TISVXA> .