hidakatsuya / prawn-emoji Goto Github PK

Just after updating to last ruby 2.4 (brew), my projects using emoji are drawing the normal .ttf fonts numbers as circled emoji numbers. Total disaster. The only solution is banning emoji and rewrite it all

Hey! Thanks for this gem!

I was just playing around with this with different emoji and fonts and found some behavior which I don't know if it is a bug or I'm missing a configuration option.

Prawn::Document.generate 'sushi.pdf' do
  font 'DejaVuSans.ttf'
  text '👁🤷‍♀️🦄'
end

produces:

The eye is part of Unicode 7.

I tested with unicode-emoji and maybe it's because it has a text representation?

» "👁🤷‍♀️🦄".scan(Unicode::Emoji::REGEX_INCLUDE_TEXT)XT)
=> [
  [0] "👁",
  [1] "🤷‍♀️",
  [2] "🦄"
]

» "👁🤷‍♀️🦄".scan(Unicode::Emoji::REGEX)
=> [
  [0] "🤷‍♀️",
  [1] "🦄"
]

Regarding unicode-emoji, is there a reason why the version constraint even contains the patch version? That way updates from 2.3 to 2.4 depend on a new release of this gem.

When an emoji is rendered, the leading for the current text box isn't subtracted from the y coordinate for the image so it ends up rendering above the baseline for a line of text with leading set.

I looked into trying to fix this, but I wasn't able to find a way to access the current leading.

Example:

@document.text '…', leading: 8

Input

テスト🍣🍣🍣スシ

Expect

テスト🍣🍣🍣スシ

Actual

Rendering an emoji in a line causes it to extend beyond the boundaries of its containing bounding box.

Example:

Overview

Twemoji is

Twitter’s open source emoji has you covered for all your project's emoji needs. With support for the latest Unicode emoji specification, featuring 3,071 emojis, and all for free.
https://twemoji.twitter.com/

prawn-emoji will use the Twemoji's emoji since v3.0.

v3.0 (Twemoji 12.04)	v2.1 or older (EmojiOne 2.0)

See also

• https://github.com/hidakatsuya/prawn-emoji/blob/master/test/pdf/emoji_rendering/expect.pdf
• https://github.com/hidakatsuya/prawn-emoji/blob/master/test/pdf/prawn_integration/expect.pdf

Status

Fixed by 5ae4c5b but not released. The release works in progress.

Consequences

• More emojis supported
• Emoji expression changes

Related Issue/PR

#20 #21

Hey!

I was wondering if draw_image shouldn't maybe close the file descriptor of image. In our usage of prawn the tend to close the file descriptor when printing images, but I'm not sure if that would somehow affect prawn-emoji in any way or if we should trust the GC with that?

After rendering a PDF I get the following output from ObjectSpace:

require 'prawn/emoji'

Prawn::Document.generate 'sushi.pdf' do
  font '/Users/kakazza/Library/Fonts/DejaVuSans.ttf'
  text '🐟 / 🔪 + 🍚 / 🍾 = 🍣'
end

ObjectSpace.each_object(File) do |f|
  puts "%s: %d" % [f.path, f.fileno] unless f.closed?
end

DejaVuSans.ttf: 26
prawn-emoji-3.1.0/emoji/images/1f35a.png: 29
prawn-emoji-3.1.0/emoji/images/1f37e.png: 30
prawn-emoji-3.1.0/emoji/images/1f363.png: 31
prawn-emoji-3.1.0/emoji/images/1f41f.png: 27
prawn-emoji-3.1.0/emoji/images/1f52a.png: 28

Overview

prawn-emojij v2.1 or older can't draw ZWJ Sequence and Combining Sequence emojis like 👨‍👨‍👦 or 1️⃣.

Status

Fixed by d622e6f with #23 Switch to Twemoji. This will be released in v3.0.

master (will be v3.0)	v2.1 or older

See also

• https://github.com/hidakatsuya/prawn-emoji/blob/master/test/pdf/emoji_rendering/expect.pdf
• https://github.com/hidakatsuya/prawn-emoji/blob/master/test/pdf/prawn_integration/expect.pdf

Related Issue/PR

#23 #20

First of all, thanks for this great gem. It works really great. But I have faced a problem when it comes to display some emojis.

When I render the pdf on Firefox all emojis are displayed nicely.

Here is a screenshot from firefox.

So far so good.

And now here is screenshot from Safari browser:

I have also opened it on Mac's default pdf viewer:

Safari & Mac's Preview behave the same and they show only smiley face. Other emojis are rendered but they have problem.
I have debuged the code and realize that prawn splits the text here if it find unicode such as any kind of emoji.

My prawn configuration:

Prawn version: 2.2.2
Prawn-emoji: 3.3.0

    font_families.update(
      'SFProDisplay' => {
        normal: Rails.root.join('app', 'assets', 'fonts', 'SFProDisplay-Regular.ttf'),
        bold: Rails.root.join('app', 'assets', 'fonts', 'SFProDisplay-Bold.ttf'),
        semi_bold: Rails.root.join('app', 'assets', 'fonts', 'SFProDisplay-Semibold.ttf'),
      },
      'DejaVuSans' => {
        normal: Rails.root.join('app', 'assets', 'fonts', 'DejaVuSans.ttf'),
        bold: Rails.root.join('app', 'assets', 'fonts', 'DejaVuSans-Bold.ttf'),
        semi_bold: Rails.root.join('app', 'assets', 'fonts', 'DejaVuSans-Bold.ttf')
      }
    )

    fill_color DEFAULT_COLOR
    font 'SFProDisplay'
    fallback_fonts ['DejaVuSans']

NOTE: If I set default font as DejaVuSans instead of SFProDisplay then all emojis are displayed.

I could not understand the problem otherwise I could open a PR. If you guide me if there is some sort of a bug I can send a PR.

zombie 🧟‍♂️ doesn't render when I test out a few common emoji issues even though it looks to be available in EmojiOne (found here https://www.emojicopy.com/)

Perhaps need to update to the latest EmojiOne 3.1.1 w/ some more images?