hf / toi Goto Github PK

None

Is there a way to validate to Record types in TOI? Specifically, how would I define validator such that:

const foo:Record<string,unknown> = validator(bar);

The instanceof operator doesn't always work when there are multiple versions of toi in one monorepo, for example. Different require statements result in multiple ValidationError classes and the check that is performed with instanceof is no longer reliable.

One approach on how can this be fixed is by introducing a boolen flag, like isToi, to the ValidationError class that will identify the error. The Joi library has the same approach.

Although there is a clear JSDoc explaining what this validator does, the name of the validator itself is misleading. I expect that it would check that a value is NaN, but it actually checks if a value is of type number. This means that all valid numbers (excluding NaN) will pass this check. I thing that this validator should be named num.isNumberType and there should be another validator which checks if the value is really NaN and it could be named num.isNaN. Will submit a PR.

something like:

toi
  .optional({default:20})
  .and(toi.num.is())

or just:

toi
  .optional(20)
  .and(toi.num.is())