heypouya / githubuserfinder

A simple Github user finder application

GithubUserFinder

Thank you for reviewing my code. :)

I'd like to share some of the design decisions I made:

• I implemented simple pagination for searching users manually instead of using the Paging library. The reason for this choice was to have full control over the data in my ViewModel and UseCase, and I wasn't satisfied with how the Paging library handled failures or refreshes.

• I apologize for the UI; I didn't have much time to work on it. In a real-life app, I typically invest more effort into UI design. 😄

• While planning the project, I considered using multiple modules for core classes and features. However, I found this approach to be somewhat redundant even for a sample application. Therefore, I opted for a single-module architecture.

• Due to time constraints, I couldn't make the following improvements:

  • Clicking on search button is not doing anything
  • Empty state is not covered
  • Empty string is not handled and will search for empty userName
  • Using a logger instead of printStackTrace()
  • The user list is not refreshable
  • Hiding the keyboard when an error message is displayed.
  • Enhancements to start fetching the next page earlier, before the user reaches the end of the list.
  • Not calling the next page when the list is short or has reached the api call limit.

I thoroughly enjoyed working on this challenge, and I hope you'll enjoy reviewing it as well.