heycarsten / ember-fsm Goto Github PK

heycarsten !

I may be being a silly boy, but it appears that willExit and didExit run on entering a state.

  /* Begin State Machine Definition */
  fsmEvents: {
    toIdentity: {
      transition: {
        from: '$all',
        to: 'identity'
        willExit() { console.log('i ran when entering the identity state! ...') },
        didExit() { console.log('...then i also ran when entering the identity state!') }
      }
    },
  },

This is being used in an FSM#Stateful service.

I was hoping to use willExit() to return a promise that will authenticate the current user when attempting a transition from the identity step. Am I being a silly boy??

Hope you're great Carsten!! Miss you man

Ensure Ember FSM can be used easily in Ember CLI projects.

My usecase for the FSM is a workflow manager for tasks. I'd love to persist the current state into a DB and revive the FSM later to promote the item. Being able to set currentState on init will allow for this. Or am I on the wrong track and is this feature already possible?

There's probably a good reason for this, but I was hoping to do:

fsmEvents: {
  toCart: {
    transition: { $all: 'cart' }
}

Instead I need to do:

fsmEvents: {
  toCart: {
    transition: { 
      from: ['$initial', '$all'],
      to: 'cart'
    }
  }
}

Feels like $all should include $initial - but maybe I'm missing something?

Hi, just checking if this message reaches any other maintainers of this repo / package that Carsten might have added prior to his passing in 2019.

I am not aware of any other maintainers but wanted to verify as I am working on minimal updates to provide compatibility with Ember 4.x / Octane (purely to aid in the upgrade process in an Ember app that still uses this library for now). If there are, I could submit a PR, otherwise my intention is to publish a fork in the next few days.

ember-cli/ember-cli#4199

Hey Carsten!!

miss u man! found another lil prototype extension we should snip

<3

just updated an addon that uses this to CLI 0.0.23 (which includes a package for addons that forces ember to disable prototype extensions, to ensure max compatibility)

Noticed ember-fsm uses .contains

Just flagging this, shouldn't be too hard

I love the automatic isInXXX properties, it's genius for logic in templates. It would be really nice to have canXXX properties too. XXX is replaced with the name of a transition.

This allows for templates to add action buttons when these actions are available.

What is your opinion, is this hard to implement?

I think recomputing the guards will be hard though.

Using the Stateful mixin in a component results in the error "Uncaught TypeError: this.currentState.legacyPropertyDidChange is not a function", as reported at emberjs/ember.js#11374

Hi,

it would be great if a function would be accepted as initialState to properly sync the FSM with a model that comes with a state and is persisted.

Best,
Tobias

Ember changed its use of the states property, particularly in views. After upgrading 1.7 -> 1.8, my app is peppered with

DEPRECATION: Usage of states is deprecated, use _states instead.

This particularly conflicts if I mix Ember.FSM.Stateful into a component (a view). ember-fsm's states property conflicts with CoreView's, resulting in

TypeError: Cannot read property 'enter' of undefined.