hexastack / wit-api Goto Github PK

Running unit tests returns :

nyc mocha --timeout 5000 --reporter nyan

17 --------------,------,
9 --------------| /_/\
0 --------------^|__( x .x)
-------------- "" ""

17 passing (43s)
9 failing

1. Wit
   Entity services
   Get one entity by name
   Should fetch an Entity:
   Error: expected [Error: Not Found] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.entity.get.then.catch.e (test/test.js:53:31)
   at process._tickCallback (internal/process/next_tick.js:109:7)

2. Wit
   Value services
   Should add a value:
   Error: expected [Error: expected [] to contain 'keywords'] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.value.add.then.catch.e (test/test.js:158:29)
   at process._tickCallback (internal/process/next_tick.js:109:7)

3. Wit
   Expression services
   Should remove an expression:
   Error: expected [Error: expected { status: 400,
   body: 'This entity needs at least one of keywords or trait lookup to be able to delete expressions',
   code: 'bad-request' } to have a property 'deleted'] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.expression.delete.then.catch.e (test/test.js:192:29)
   at process._tickCallback (internal/process/next_tick.js:109:7)

4. Wit
   Learning
   Train using one sample at a time
   Should yeild on a json response:
   Error: expected [Error: expected [Error: You tried to create 'wit$greetings'. Use POST /entities instead] to be falsy] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.train.then.catch.e (test/test.js:246:31)
   at process._tickCallback (internal/process/next_tick.js:109:7)

5. Wit
   Text messages
   Test on a learned text
   Should respond by an Intent Object:
   Error: expected [Error: expected {} to not be empty] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.message.then.catch.e (test/test.js:283:31)
   at process._tickCallback (internal/process/next_tick.js:109:7)

6. Wit
   Text messages
   Test on a forgotten text
   Should respond by an Intent Object containing greeting:
   Error: expected [Error: expected {} to not be empty] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.message.then.catch.e (test/test.js:301:31)
   at process._tickCallback (internal/process/next_tick.js:109:7)

7. Wit
   Speech
   Should respond by an Intent Object:
   Error: expected [Error: expected 'Hello' to equal 'hello'] to be falsy
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.ok (node_modules/expect.js/index.js:115:10)
   at Function.ok (node_modules/expect.js/index.js:499:17)
   at wit.speech.then.catch.e (test/test.js:319:29)
   at process._tickCallback (internal/process/next_tick.js:109:7)

8. Wit
   App Management
   Delete an App
   The latest wit instance shall not work
   Should trigger error:
   Error: expected [Error: expected { name: 'intent',
   id: '5b73fa2b-cf19-4591-a653-eb78a8dc719f',
   values: [],
   builtin: false,
   doc: 'User-defined entity',
   lang: 'en',
   lookups: [ 'trait' ],
   request: [Function] } to be falsy] to have a property 'code'
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.property (node_modules/expect.js/index.js:381:12)
   at newWit.entity.get.then.catch.e (test/test.js:406:31)
   at process._tickCallback (internal/process/next_tick.js:109:7)

9. Wit
   Error handeling
   Api fails
   Should fail & return Error instance with a message and code props:
   Error: expected 'no-auth' to equal 'unknown'
   at Assertion.assert (node_modules/expect.js/index.js:96:13)
   at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
   at Assertion.(anonymous function) [as be] (node_modules/expect.js/index.js:69:24)
   at defectedWit.entity.list.then.catch.e (test/test.js:424:29)
   at process._tickCallback (internal/process/next_tick.js:109:7)

-----------------|----------|----------|----------|----------|-------------------|

Got the following error when calling Wit.train() :

{
"error" : "You need to provide an array of samples",
"code" : "bad-request"
}

According to the documentation, the body must be an array. That said, maybe changing the method so i can support having an argument with one or a set of samples.

New parse payload have the following data structure :

{"text":"Bonjour","intents":[{"id":"467958847129146","name":"greeting","confidence":0.9986}],"entities":{},"traits":{"language":[{"id":"0596e762-b648-4e55-84ff-2fbaa4eca22b","value":"fr","confidence":0.9989}]}}

I don't know how much it will impact the current code. We must review the full API documentation.

@bashz i would recommend tagging the current branch before

There are two issues :

• HTTP request method is sent as POST instead of PUT
• request var is undefined in the update() method

We need to add a method in order to delete a training expression.

When sending train(), WIT API is not accepting samples when text length is greater than 280.

Two solutions are available : Either slice the text or return an error

@bashz : What do you think ?

Wit.entity.delete() fails when making multiple calls. The second call always concatenates the entity id in URL with the previous one.

{ 
  method: 'DELETE',
  uri: '/entities/5b0eaea8-3531-4138-8b18-555a2968de07/5b0eab46-b8c8-4438-a1f3-24522bf0311c'
}

I guess this could be also the case for other methods ... must check.