herodotusdev / herodotus-evm Goto Github PK

View Code? Open in Web Editor NEW

15.0 4.0 6.0 1.99 MB

Herodotus EVM contracts

License: GNU General Public License v3.0

Solidity 95.94% JavaScript 4.06%

ethereum herodotus storage-proofs

herodotus-evm's People

Contributors

Stargazers

Watchers

Forkers

officialnico popraf gmh5225 janicedcolon solidml

herodotus-evm's Issues

Ensure that the Optimism L1 to L2 communication system works properly

Update README.md

Apply the `Nullable` lib

`NullableStorageSlot` choose `NULL_VALUE` in the upper `uint256` bound

Implement `verifyAccount` in `FactsRegistry`

Resolve the TODO related to passing the MPT value

Handle verifying a proof for an element not existing in the trie

Verifying a proof for an element that does not exists in the trie fails with MerkleTrie: ran out of proof elements.
The reason is that this verifier is not meant to also detect non-inclusion.

The way this should be fixed is by relying on the older version of the same library also from Optimism.
Audited by OpenZeppelin in 2021.

https://github.com/ethereum-optimism/contracts/blob/master/contracts/optimistic-ethereum/libraries/trie/Lib_SecureMerkleTrie.sol

Refactor the usage of Nullable to `for uint256 use Nullable ...`

Implement `verifyStorage` in `FactsRegistry`

Update the TimestampsRemapper so it works with the latest changes and is compatible with the one in Cairo

Test the new MPT verifier

Ensure that ZkSync L1 to L2 communication works

Update deployment script of the Core components

Apply Aimeric feedback

Forge: Incompatible Solidity versions

Replication:

cloned repo
pnpm install
forge install
forge test

returns this

Unit test the libs and contracts

Emit event in Headers Store when blockhash is received

Fix the proveAccount test, something silly with the test case

Open source

Resolve nonce decoding issue

The way values decoded from an RLPItem is wrong.
The library returns valid bytes however the way we later covert it an uint256 is wrong as it loads garbage from the memory.

The recommended way to fix is to rely on an older version of the RLP library also from Optimism.
Audited by OpenZeppelin in 2021.

https://github.com/ethereum-optimism/contracts/blob/master/contracts/optimistic-ethereum/libraries/rlp/Lib_RLPReader.sol