henkelmax / trade-cycling

The trade cycling functionality of Easy Villagers.

Trade Cycling

CurseForge | GitHub

---

This mod adds the trade cycling functionality of Easy Villagers.

trade-cycling's Issues

[Fabric, 1.19.2] Mason cycle button

Bug description
Hello,
the cycle button don't work with the mason.

Steps to reproduce the issue

1. Place a stonecutter
2. Summon a Villager
3. magic Mason Villager
4. Click the cycle button and nothing will change

Expected behavior
New trades

Log files
https://pastebin.com/YGFETEBS
(these are the log files in a larger modpack, but I tested it with a small test pack with the mods below)

Versions

• 1.19.2
• Fabric: 0.14.9
• trade-cycling-fabric-1.19.2-1.0.5

Other mods

Screenshots (Optional)

Why doesnt trade cycling work in realms

i would like some assistance on why the mod Trade cycling works in other severs besides realms because I have multiple mods in that same realm and have no issue so could someone assist me please

Cured Villagers Loose Their Discounts

When you press the cycle button for a cured villager, it instantly looses all discounts. This needs to be fixed soon.

Steps to reproduce the issue

1. Cure a zombie villager
2. Give it any job
3. Press the cycle button
4. All discounts get removed

Expected behavior
The Villager should have just gotten new trades and kept the discounts.

Versions

• 1.19
• Fabric
• Mod version 1.0.3

Other mods
Better f3
borderless mining
continutiy
sodium

Screenshots of the issue and list of mods.

[1.18.2] Problem with Village Artifacts/Tools

Bug description
If I use the "Grimoire of the Lost Merchants Guild" (from Village Artifacts) and make a villager to be max level (Level 5/Master) I can Trade Cycle and they will cycle the last level's offers and "delete" the rest.

Steps to reproduce the issue

1. Have a villager level up with "Grimoire of the Lost Merchants Guild"
2. Trade Cycle them
3. They will only offer the last trade

Expected behavior
They shouldn't be able to be cycled

Versions

• Minecraft version : 1.18.2
• Forge/Fabric version : Forge 40.1.80
• Mod version : 1.0.2

Other mods
Village Artifacts
Tested on both modded villagers and vanilla

I don't know if this is Trade Cycling's problem or Village Artifacts so please tell me weather I should report this to them.

Screenshots (Optional)

Trade Button Location

Right now when when used in conjunction with Villager Names by Serilum the trade cycle button ends up behind their names which doesn't look proper.

I know in the config you can choose from TOP_RIGHT, TOP_LEFT, or NONE, but if we could get a system to move it around based on pixels I feel that would solve any type of problem like this.

doesnt work at all

Bug description
when pressing the hotkey in the trading menu or trying to find the button in the trading menu the button is gone and the key does nothing no matter what its set to. You had one job.

Steps to reproduce the issue

1. Open 1.18.2 forge
2. Click on trading menu
3. Error

Expected behavior
Trade cycle function worked

Log files
Please provide log files of the game session in which the problem occurred.
attached below

Versions

• Minecraft version 1.18.2
• Forge/Fabric version 40.2.1
• Mod version one from 3/2; the only one on this version

Other mods
A list of the other mods that were installed when this problem occurred.
It would be ideal if you could test if this problem persists when no other mod is installed.
If not, please narrow down the mod(s) that are causing the problem.
probably Quest Giver; the modpack is dawncraft and you have to do some fetch quests for villagers to gain reputation before you can trade

Screenshots (Optional)
Screenshots of the issue.

latest.log

Can trade cycling work on realms?

MC Encyclopedia

Will this mod be published on MC Encyclopedia, and if not, can I reprint it?

suggest

Would you like me to upload this mod to Minecraft?

[1.18.2] Configs about Button Location

Bug description
I wanted to find the config file to change the button location (as is mentioned in the Curseforge page "Configurable trade cycling button location") but I wasn't able to find it in neither "config" not "serverconfig" folders so I use the Configured mod to do it in-game and then crashed.
This might be a Feature for maybe only Fabric or 1.19.x but I didn't find anything more about it.

Steps to reproduce the issue

1. Go to mods
2. Select Trade Cycling config
3. Change the location to None or Top Right
4. Save Changes
5. Crash

Log files
Log
I found this line here :
Caused by: java.lang.NullPointerException: Cannot invoke "com.electronwill.nightconfig.core.UnmodifiableCommentedConfig.configFormat()" because "config" is null
And on the Crash Screen :
Error: java.lang.NullPointerException: Cannot invoke "com.electronwill.nightconfig.core.UnmodifiableCommentedConfig.configFormat()" because "config" is null

Versions

• Minecraft version : 1.18.2
• Forge/Fabric version : Forge 40.1.80
• Mod version : 1.0.2

Other mods
Happens also with these mods:
Catalogue : 1.6.2
Configured : 1.5.4
Trade Cycling : 1.0.2

Having Trade Cycling in a server prevents it from starting up.

Bug description
Can't load a server with trade cycling installed.

Steps to reproduce the issue

1. Have/make a server
2. Try to launch it with Trade Cycling

Expected behavior
Server starts normally, happiness, rainbows and rabbits ensue.

Log files
https://gist.github.com/TeraBitGaming/1c3f6bcbaaf34bca0ec4b0f7e36b1b74

Versions

• Minecraft version: 1.18.1
• Forge version: 39.0.1
• Mod version: 1.0.0

Other mods
None others were reported in the crash.
screenshot of the used mods:
https://i.imgur.com/Pb1W3sC.png

mod is not working

Bug description
the mod is not working

Steps to reproduce the issue
I install the mod and is not working

Expected behavior
I expected to work

Log files
idk where and idk if I have because it not give me any error

Versions

• 1.19.4
• fabric - 0.14.21
• 1.0.5

Other mods
I the foto

can you backport this to 1.17.1 fabric

its okay if you can't
that’s completely understandable
I just wanted to ask that’s all
please if you can just try that would be very helpful