hemanth / blns

Big List of Naughty Strings.

A computer polyglot. CLI, web && FOSS philosopher.

Member of the Technical Staff at PayPal.

Ambidextrous, native Bangalorean! Currently living in CA.

Blog's about programming and have archived his old blog.

Curator JSfeatures.in. Tech Speaker and Podcaster.

Community leader at DuckDuckGo. Members - Node.js Foundation. TC39 delegate.

Google Developer Expert in Web and Payments domains.

Feel free to AMA.

@gnumanth on twitter.

blns's Issues

Post Install fails when default shell is not bash

[[ is a bash builtin, and not available on systems where the default shell is /bin/sh

As shown below:

accalia_de_elementia@sockdrawer:~/workspace/SockBot (integration) $ npm install --save-dev blns
/
> [email protected] postinstall /home/ubuntu/workspace/SockBot/node_modules/blns
> [[ -x $(which git) ]] && git submodule update --init --recursive || echo 'You don't have git installed, so can't update the list'

sh: 1: [[: not found
You dont have git installed, so cant update the list
[email protected] node_modules/blns
accalia_de_elementia@sockdrawer:~/workspace/SockBot (integration) $

The postinstall script should not assume a BASH environment.

Why not copy the file?

If we copy blns.json from Big List of Naughty Strings's repo or use .gitmodules or any others, we can keep api more graceful like this:

// index.js
module.exports = require('./blns.json');

var blns = require('blns');
// => [ ... ]

http request will hurts test performance and repo url maybe changed as time goes on. Bumping version for update will be a good choice.

Please update

The README says : Up to date Big List of Naughty Strings

It isn't.

post-install script should not depend on git

Hi, we (FiftyThree) recently installed this npm module and we're so glad that we have access to blns! However, some of our environments do not have git installed. So when we deploy to those environments the installation fails due to post-install. We have removed that script for now in our repo, but would be good not to assume that installation environments have git.

Thanks,
Andrew Chan