hemangshah / hhtabbarview Goto Github PK

For example create a view/view controller with table with a lot of items and try to scroll it to the bottom - the last cell is hidden by tab bar

I tried to use with pod, but when I opened project it says code is developed with swift 2.x, I need to first migrate code using xcode 8

Tab 1 ↠ Navigation Controller ↦ View Controller 1 → View Controller 2 → View Controller 3

So we're in View Controller 3 and by tapping on the same tab (Tab 1) again, I will now take back to View Controller 1 (the first view-controller in navigation controller hierarchy).

To achieve this, I've made a slight change in on tab tapped closure block:

        hhTabBarView.onTabTapped = { (tabIndex, isSameTab, controller) in
            if isSameTab {
                if let navcon = controller as? UINavigationController {
                    navcon.popToRootViewController(animated: true)
                } else if let vc = controller as? UIViewController {
                    vc.navigationController?.popToRootViewController(animated: true)
                }
            }
            print("Selected Tab Index:\(tabIndex)")
        }

With this, there'll be a possible highlight issue will occurs as part of this change in 2.3.0, to fix this:

I am suggesting this solution: Integrate this functions in View Controller 1 (and all other where you will have similar navigation flow).

    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        // This will be helpful in locking the current tab if we're already in the first view-controller in navigation flow.
        HHTabBarView.shared.lockCurrentTab()
    }
    
    override func viewWillDisappear(_ animated: Bool) {
        super.viewWillDisappear(animated)
        // This will be helpful to unlock the locked tab when we're going forward from the first view-controller in navigation flow.
        HHTabBarView.shared.unlockAllTabs()
    }

P.S. Thanks Nishan for coming up with this issue. 🙏🏼

HI Hemang,

After changing the tabBarViewPosition to bottom, if you tap on any tab or on the screen the first tab will be selected.

Regards,
Dipak

Here i added 6 tab, but only 5 tabs are works and other tab's tab-button appears but doesn't work.
Someone had solution for this please help., Thanks in advance

Originally posted by @chiragpurohit71085 in #8 (comment)

Good day Sir @hemangshah ,

I am a graphics designer and i want to contribute on your project by designing a logo for it as a gift for free if you will permit me. I have noticed you don't have logo yet. Ill wait for your approval first before I start.

Thanks and best regards!
-Tobaloidee

tab bar push down when toggle in call status bar

Done.