helmasaur / horsengel-roulette

A discord.js russian roulette where the loser gets kicked.

Summary

Welcome here! I am Helmasaur and I live in Paris, France.

For now, you can mostly find projects related to discord.js, but some other things might slowly appear. I might be talking about a CMS and a video game 👀.

Stay tuned!

How to reach me

🐦 Twitter: @helmasaur
📷 Instagram: @helmasaur
🐽 Discord: Helmasaur#1138

Statistics

NOTE: Top Languages does not indicate my skill level or anything like that. It's a GitHub metric of which languages have the most code on GitHub. It's a new feature of github-readme-stats.

horsengel-roulette's Issues

Check bot permissions

For a working Horsengel roulette, the bot requires those permissions:

• SEND_MESSAGES
• KICK_MEMBERS
• CREATE_INSTANT_INVITE

Real test file

Creation of a real test file instead of a demo file.

Typo in the readme file

Commando.js markdown link needs to be fixed.

The bot doesn't wait for the opponent's answer

The bot doesn't wait for !yes before to start the game. await is missing.

Use files to manage strings

Strings are hard coded. They should be managed in JSON files.

Several bullets and different chamber size

Make tests to be sure that the game works regardless the number of bullets or the size of the chamber.

Wrong prefix in the README example

? should be replaced by !.

Thank the TypeScript compatibility author in the readme file

Also thank Horsengel.

Remove italic formatting in strings

Update to discord.js v14

Coming soon

Update the README file for discord.js v14

Things to change:

• discord.js version;
• Node.js version;
• remove mention of Commando;
• use variables in the example (#56);
• Link to the profile of Lioness100.

Add the git repo link to package.json

More than two players

Add the possibility to play to a Horsengel roulette with more than two players.

Example for Commando.js Framework [discord.js]

I would be helpful if you tell me more about how to make it work in commando framework. I got the !hr play , I will just check if the user accepts or not in the play command file, but what is !pan ?

Message for the compatible discord.js version in the readme file

Add a paragraph to the readme file saying that the bot is only compatible with discord.js v12 and for discord.js v11, the version v1.0.4 should be used.

Missing await

When lost the game rich embed can be displayed after the kick message.

Use a variable for time the bot takes to answer and the time a player has to answer

Put urls in package.json in lower case

The packages and my username has been put back to lower case like most of GitHub.

Update index.d.ts for discord.js v14

No DM when the bot kicks because he doesn't want to play

The direct message and the kick rich embed message aren't sent when the bot kicks the member asking for a Horsengel roulette.

When the bot doesn't want to play, a message is sent twice

The kick message is sent twice:

?kick @Helmasaur don't bother me with a Horsengel roulette
?kick @Helmasaur don't bother me with a Horsengel roulette

Fix importation in the example

Instead of const HorsengelRoulette = require('..');, it should be const HorsengelRoulette = require('horsengel-roulette');.

Wrong bullet place when the game is against the bot

The condition where the chamber is filled depending if the opponent is the bot or not should be reversed.

Better comments

Update README

Update README so it's accurate with the modification done on the code.

Do not forget:

• discord.js version;
• check about Commando;
• modify the example;
• link to the people listed in the thanks.

Sort methods

Sort methods in a better way. At the moment, it's too chaotic!

Add npm keywords

Game against an other bot

It should be impossible to kick the bots which are on the a server.

Last paragraph of "how to play" has mistakes

Sentences aren't well written in the last paragraph of "how to play".

When the bot doesn't want to play, the kick message is sent even if the player can't be kicked

Such as normal games, if the bot kicks the player because it doesn't want to play, an other message should be sent because the kick won't 't work anyway.

Replace XXX by the right variables

Some strings don't include the player variable but XXX.

Object referred attribute missing

this is missing for those both lines.

https://github.com/Helmasaur/Horsengel-roulette/blob/b0f689d082c07d0f3d2a68508227bad80a16f0ec/index.js#L85-L86

Use variables for prefixes

All command prefixes in strings should be replaced by a varaible.

The invitation link can't be created

The property defaultChannel doesn't exist anymore.

https://github.com/Helmasaur/Horsengel-roulette/blob/5e69695ac48a2e0db9979deccba2628e07664aa9/index.js#L178

Check if this package works with discord.js v12

Create a branch for discord.js v13

Discord login missing in the readme example

client.login(); should be added at the end of the example.

The loser isn't kicked

Add the permissions and the privileged intents required for the Horsengel roulette to work

Update the license to 2021

horsengel-roulette/locales/en/common.json: Unexpected end of JSON input

3|m | SyntaxError: /root/mustafa/node_modules/horsengel-roulette/locales/en/common.json: Unexpected end of JSON input
3|m |     at parse (<anonymous>)
3|m |     at Object.Module._extensions..json (internal/modules/cjs/loader.js:1041:22)
3|m |     at Module.load (internal/modules/cjs/loader.js:863:32)
3|m |     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
3|m |     at Module.require (internal/modules/cjs/loader.js:887:19)
3|m |     at Module.Hook._require.Module.require (/usr/lib/node_modules/pm2/node_modules/require-in-the-middle/index.js:80:39)
3|m |     at require (internal/modules/cjs/helpers.js:74:18)
3|m |     at new HorsengelRoulette (/root/mustafa/node_modules/horsengel-roulette/index.js:24:19)
3|m |     at BankCommand.run (/root/mustafa/commands/minigames/roulette.js:32:16)
3|m |     at Message.run (/root/mustafa/node_modules/discord.js-commando/src/extensions/message.js:222:34)
3|m |     at processTicksAndRejections (internal/process/task_queues.js:97:5)
3|m |     at async CommandDispatcher.handleMessage (/root/mustafa/node_modules/discord.js-commando/src/dispatcher.js:144:19)

This is the error i get while starting the game

my code:

 const prefix = msg.guild.commandPrefix

    const hr = new HorsengelRoulette(msg, msg.member, opponent, '!', 'en');
		hr.load(6, 1); // Chamber size and number of bullets
		hr.start();

Update the license date for 2023

2021 -> 2023

Invintation link and kick message missing after the kick

No PM is sent at the end of the Horsengel roulette to the loser who has been kicked.

Thanks to Dubois for finding this bug.

Random amount of time for the bot to answer

An infimum and a supremum should be set.

Variables for the number of bullets and size chamber in the test and readme file

In the test file, the number of bullets and the size chamber is raw data. It might be better to store them into a variable for a clearer example. Alternative: add a comment after the line.

horsengel-roulette/test/test.js

Line 21 in 627b603

hr.load(6, 1);

Check if the bot has the right to kick

Send a message if the bot doesn't have the right to kick.

Horsengel roulette is broken

This happens because the module will waits for the answer of the provoked person. The code doesn't include a part for the bot as the opponent.

Thanks to orange88 for finding this bug out.

Use emojis to accept or reject a duel

For example, the emojis ✅ and ❌ could be used.

The message created by the bot after the command !hr used, both emojis should be added. The first one which is clicked by the provoked member should trigger the game or cancel it.

Should this change be made?

Doesn't work if the bot's main code is on discord.js v13

I've tried to use this package for a command for my discord.js v13 discord bot, but it doesn't seem to work at all.
The only thing it does is prompt the user to use "!yes" to start and it stops there, doesn't matter if the other user says "!yes" or not.

Add the event message in the README example