helidium / mitol Goto Github PK

npm install produces:

In file included from ../mns.cc:1:
../http.h:10:10: fatal error: '../src/Server.h' file not found
#include "../src/Server.h"
         ^

npm: v4.6.1
node: v6.11.1

express.js
`const express = require('express');
const app = express()
const http = require('mitol');

app.get('/', (req, res) => {
res.send('Hello World!');
});

http.createServer(app).listen(3000, () => {
console.log('Example app listening on port 3000!');
});`

kao.js
`const mitol = require('mitol');
const Koa = require('koa');
const app = new Koa();

// response
app.use(ctx => {
ctx.status = 200;
ctx.body = 'Hello World!';
});

mitol.createServer(app.callback()).listen(3000);`

wrk -t12 -c400 -d3s http://127.0.0.1:3000/

Running 3s test @ http://127.0.0.1:3000/
12 threads and 400 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 0.00us 0.00us 0.00us -nan%
Req/Sec 0.00 0.00 0.00 -nan%
0 requests in 3.10s, 0.00B read
Socket errors: connect 0, read 15897, write 0, timeout 0
Requests/sec: 0.00
Transfer/sec: 0.00B

im trying mitol with express but if using morgan logger express try remote access or something here error report:
Cannot read property 'remoteAddress' of undefined

TypeError: Cannot read property 'remoteAddress' of undefined
at forwarded (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/forwarded/index.js:31:35)
at alladdrs (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/proxy-addr/index.js:57:15)
at proxyaddr (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/proxy-addr/index.js:231:15)
at IncomingMessage.ip (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/express/lib/request.js:351:10)
at getip (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/morgan/index.js:466:14)
at logger (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/morgan/index.js:107:26)
at Layer.handle [as handle_request] (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/express/lib/router/index.js:317:13)
at /mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/express/lib/router/index.js:284:7
at Function.process_params (/mnt/c/Users/x0nim/Desktop/workspace/avukat-node/node_modules/express/lib/router/index.js:335:12)

Is there an effort being made on this project still?

I'd like to see a roadmap, basically a list of features that the http module has that mitol will eventually implement. The roadmap should go in the README.md file.

Also, a list of quirks where mitol differs from the http module would be much appreciated. This list would not include missing features, since that's what the roadmap is for.

This will help users understand where the project is lacking, and maybe even inspire more contributors.

Thanks!

Hi there! Would love to try this out in real products, but realistically, it would only be feasible if I could load this in via npm.

Is there any way that this is possible?

FWIW, as of writing this, the name mitol is available.

The response object is a plain object. It should extend ReadableStream

In most cases even 'hello world' server quits with segfault when trying to reach smth like 2k rps on linux.
Output on mac differs a bit, returning malloc and/or 100% CPU.

Tried to make "hello world" post/put request handler but it does not seem to work (while GET does work as expected)

Here's the code:

const http = require('mitol');

let server = http.createServer((req, res) => {
  if (req.method === 'GET') {
    res.end('Hello World!'); // works as expected
    return;
  }

  var str = '';
  req.on('data', function(data){
    str += data;
  });
  req.on('end', function(){
    res.end('POST pingback', str);  // never fires
  });
});
 
server.listen(8099, () => {
    console.log('Example app listening on port 8099!')
});

Various libraries (including) express modify the value of the URL (e.g for serving sub apps). This is incompatible with mitol as the field is implemented as a const char

var server = http.createServer();


  server.on('request', function(req, res) {
    ...
  });

Function never gets registered/called.

Here's the code:

const http = require('mitol');

let server = http.createServer((req, res) => {
    res.statusCode = 400;
    res.end();
});
 
server.listen(8099, () => {
    console.log('Example app listening on port 8099!')
});

Nothing is returned in response (lets say timeout).
When trying to set e.g statusCode = 404, it works as expected.

I'm running an ultra simple server with koa and I'm seeing this

  TypeError: x.ee.removeListener is not a function
      at cleanup (/Users/omni/Documents/git/drive-proxy/node_modules/ee-first/index.js:62:12)
      at callback (/Users/omni/Documents/git/drive-proxy/node_modules/ee-first/index.js:54:5)
      at onevent (/Users/omni/Documents/git/drive-proxy/node_modules/ee-first/index.js:93:5)
      at respond (/Users/omni/Documents/git/drive-proxy/node_modules/koa/lib/application.js:229:43)
      at handleResponse (/Users/omni/Documents/git/drive-proxy/node_modules/koa/lib/application.js:134:36)
      at <anonymous>

fish: 'node index' terminated by signal SIGSEGV (Address boundary error)

Here is what I'm running

const mitol = require('mitol');
const Koa = require('koa');
const app = new Koa();

// response
app.use(ctx => {
  ctx.status = 200;
  ctx.body = 'Hello';
});

mitol.createServer(app.callback()).listen(3000);

This works without fail when I'm using http as normal

Build error

My Node is 6.10.3

npm is 3.10.10

Check the request content type for proper data retrieval type.

npm install https://github.com/Helidium/Mitol.git won't work because you don't have a package.json in the repo

Is there any way i can use mitol instead of native node js https ?

As per #15 currently request.connection is missing. This breaks logging middleware in express (e.g morgan) as well as some authentication solutions.

I'm just curious how come the techempower benchmarks are showing mitol with a ~20% improvement over the default implementation, while the readme is claiming a 3x improvement?

https://www.techempower.com/benchmarks/#section=data-r15&hw=ph&test=plaintext&l=h4s9h9

HI, thanks for your effort in this project. I want ask you, what is the status of this project. Is usable on production?

Is it possible to support node 10?

server.on('connection', callback) leads to error server.on is not a function
same as server.unref()