helhum / realurl

TYPO3 CMS Extension RealURL fork

TYPO3 Extension realurl

This is an unofficial fork of the TYPO3 CMS Extension RealURL It aims for no backwards compatibility with TYPO3 versions lower than 6.2 thus no messages in the deprecation log.

As the class names changed the configuration needs some slight change, too:

'userFunc' => 'Tx\\Realurl\\UriGeneratorAndResolver->main'

Other than that, configuration and behaviour (including potential bugs) are the same.

This fork comes with no support. If you find bugs or have questions, you may want to use the original version: https://github.com/dmitryd/typo3-realurl

realurl's Issues

Usage for 8.4

can you allow 8.4 in your composer.json as well?

Tagged "2.0.1" in git but backend says "2.0.0"

Git tag states version number "2.0.1", but backend based on ext_emconf says "2.0.0".
Just minor confusion

Missing core labels for depth selection in RealURL management module

realurl/Classes/View/AdministrationModuleFunction.php

Line 82 in 8fd0036

0 => $GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.php:labels.depth_0'),

The labels for selecting the depth of cache and mapping information are missing in TYPO3 8.7, they need to be referenced from lang/Resources/Private/Language/locallang_core.xlf

Class loading is broken

realurl isn't compatible with the recent class loading changes in TYPO3 yet

IconUtility still in use

Class 'TYPO3\CMS\Backend\Utility\IconUtility' is still in use. altough it is outdated since 7.5
https://wiki.typo3.org/TYPO3.CMS/Releases/7.5/Deprecation#Deprecation:_.2369057_-_Deprecate_IconUtility_and_move_methods_into_IconFactory
But but composer.json and ext_emconf.php both say "~8.2.0"

Is there going to be a fix for this?

lookupTable and languagField / transOrigPointerField does not work correctly

The check in regards to the languageField is:

 if ($cfg['languageGetVar'] && $cfg['transOrigPointerField'] && $cfg['languageField'])

languageGetVar is wrong here because it is not part of the lookUpTable configuration but of the general pagePath setting. Simplest check is probably if $this->detectedLanguage >= 0

Might be used somewhere else in the method too.

chash cache doesn't take take root page into account

Summary

The internal chash cache (database table tx_realurl_chashcache) maps a given combination of query string and query parameters to a single chash value. It's intended to not recalculate chashe values when resolving GETvars from SEO URLs but to just look them up.

This can conflicts when common non-page records should be displayed on different detail pages on different root pages that share the same language and by accident the same page path to the detail page.

Example

Given a page tree like this:

• first-domain [1]
  • new-details [2]
• second-domain [3]
  • news-details [4]

Given a news record "testnews" with News-ID 10.

The news record is to be shared across both root pages.

There are two URLs to the same news record:

Encoded URL	Decoded URL
https://first-domain/news-details/testnews	index.php?id=2&news=10&chash=foo
https://second-domain/news-details/testnews	index.php=id=4&news=10&chash=bar

Expected

The database table tx_realurl_chashcache should look like this:

spurl_hash	chash_string	spurl_string
aaaaa	foo	first-domain/news-details/testnews
bbbbb	bar	second-domain/news-details/testnews

Actual behavior

The database table tx_realurl_chashcache looks like this:

spurl_hash	chash_string	spurl_string
bbbbb	bar	news-details/testnews

Solution

There's the \Tx\Realurl\Hooks\UrlRewritingHook::$additionalParametersForChash.

This can be used to add the current hostname to the chash cache.

encodeSpURL_cHashProcessing doesn't exclude `FE.cHashExcludedParameters`

Not 100% this is how it should work. But IMO
UrlRewritingHook::encodeSpURL_cHashProcessing() should exclude $GLOBALS['TYPO3_CONF_VARS']['FE']['cHashExcludedParameters'] from the parameter check to determine if chash still needs to be added to the url.

Class t3lib_lock not found in 7.4 when automatic configuration is enabled

I'm using TYPO3 7.4 and this realurl version. When the automatic configuration is enabled (in extension settings), I get the following error:

Fatal error: Class 't3lib_lock' not found in /.../typo3/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 4349

If I deactivate it, the error is gone. Probably a problem with removed t3lib_lock class in TYPO3 7+?

Domain _GET vars can be overridden

When a domain has configured a $_GET var (most prominently L), a visitor can still set that variable to a different value, leading e.g. to a different language being shown. The decode step will then not set the preconfigured value (see adjustConfigurationByHostDecode()).

IMO if a variable is defined in the domain record, it should not be changeable from the outside, or at least there should be an option to declare the value immutable.

What's the difference between upstream EXT:realurl

The README just points to removed backwards compatibility. However upstream EXT:realurl meanwhile dropped compatibility for <6.2 and moves towards >= 7.6

Is there another benefit from using your extension instead of the upstream from Dmitry?

RSS Feed won't work

i use the basic setup from all the example e.g. news docu.

'fileName' => [
        'defaultToHTMLsuffixOnPrev' => false,
        'acceptHTMLsuffix' => 1,
        'index' => [
            'feed.xml' => [
                'keyValues' => [
                    'type' => 9818,
                ],
            ],
        ],
    ],
],

TS

[globalVar = TSFE:type = 9818]
config {
    disableAllHeaderCode = 1
    xhtml_cleaning = none
    admPanel = 0
    metaCharset = utf-8
    additionalHeaders = Content-Type:application/xml;charset=utf-8
    disablePrefixComment = 1
}

pageNewsRSS = PAGE
pageNewsRSS {
    typeNum = 9818
    10 < tt_content.list.20.news_pi1
    10 {
...

TYPO3@git-master (i also tested 7.4.0 before)
realurl@git-master

/feed.xml - fails
/feed.xml?type=9818 - works

Where did i mess up?

PHP 7.2 - Method create_function is deprecated in UrlRewritingHook

In the class UrlRewritingHook, line 1127, the deprecated php method create_function() is used. Should be replaced with a compatible definition for the latest php versions.

If you are running TYPO3 v8.7 LTS with PHP 7.2. an exception with the deprecation warning is thrown.

Warning: This function has been DEPRECATED as of PHP 7.2.0. Relying on this function is highly discouraged. see: http://php.net/manual/en/function.create-function.php

Classes/Hooks/UrlRewritingHook
array_walk($pathParts, create_function('&$value', '$value = rawurldecode($value);'));

Installation fails on TYPO3 6.2 without composer mode

Error message is:

Oops, an error occurred!
The package "realurl" depends on "symfony/polyfill-mbstring" which is not present in the system.

After removing the file composer.json, the extension works fine.

Packagist availability

Hi Helmut,

Any chance we can get this (working!) patch on Packagist, too? Currently I'm cloning and adding an autoload path in composer in order to operate on 7.4.

Thanks ;)