hedhyw / go-import-lint Goto Github PK

There is typically a separate import statement when importing "C".
E.g. https://pkg.go.dev/cmd/cgo

It would be nice if this is supported instead of raising a warning.

Hey, I cannot use the lib anymore with a newer version of golang because of :

SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.

The fix is just to replace in walker.go

var files []os.FileInfo
	files, err = io.ReadDir(path)

with

var files []os.DirEntry
	files, err = os.ReadDir(path)

Can you please update the lib ?

Just out of curiosity, is there some standard for leaving unused imports in a separate block?
I don't see it in https://github.com/golang/go/wiki/CodeReviewComments#imports

I also tried searching in the Go codebase and it is a bit inconsistent. E.g.
https://cs.opensource.google/go/go/+/refs/tags/go1.19.1:src/time/time.go;l=83

Related to #1 #2

Allow line before unused imports:

import (
    _ "github.com/lib/pq"
)