hbtalha / genius_lyrics

Download song lyrics and metadata from Genius.com

const bool tiredOfLearning = false;

📚 I’m currently learning

• Web-Development(front/back-end)
• Android Development (Android Studio - Java)

🔥 Streak Stats

📊 Stats

Contact me:

genius_lyrics's Issues

There are weird words after lyrics

Hi, thanks for the library.

I found out an issue: There are weird words after lyrics such as Embed, 11Embed, 99Embed,...
Is it caused by the HTML parsing process?

test: passing token as environment variable

Since the Genius token is being set in the code, it's easy to unintentionally commit it when contribute to this project, for instance:

1. I fork this repo
2. Create a token on Genius
3. Put the token on example/main.dart and test/genius_lyrics_test.dart
4. Add my code
5. Do git add ., git commit -m "message" and git push without thinking 😳

Instead, we could use:

Genius genius = Genius(
    accessToken: const String.fromEnvironment('GENIUS_TOKEN'),
);

and, for instance, run tests with dart --define=GENIUS_TOKEN=<token> test -c vm:source or flutter test --dart-define=GENIUS_TOKEN=<token>

Minor typo: "albunsRoute" should be "albumsRoute"

It looks like there's a very minor typo in lib/api/routes.dart:

const String albunsRoute = '$_apiRoute/albums';

Super cool package, by the way!

Error: Connection closed while receiving data

When getting the info for a song, I sometimes get the error Error: Connection closed while receiving data.

I have no idea why it happens, as it looks random to me. Sometimes it happends, sometimes it works well.

I am simply using the following line (with the genius variable correctely initialized) :

final song = await genius.searchSong(artist: artist, title: title);

_TypeError (type '_Map<String, dynamic>' is not a subtype of type 'String')

Artist? artist = await genius.searchArtist(
        artistName: "Nobuo Uematsu", maxSongs: 1);

The only verbose output is: flutter: Searching for songs by Nobuo Uematsu

Causes the following error: _TypeError (type '_Map<String, dynamic>' is not a subtype of type 'String'). So it seems if no data is returned, that raises this error. Searching for"Nobuo Uematsu" on genius.com finds the artist as the top result: https://genius.com/artists/Nobuo-uematsu

Incidentally, I only intend to use the library to get the artists image url artist?.imageUrl - I'm not interested in the songs or any other non-artist related data.

Parsing issues

I noticed two issues in the lyrics:

• X Contributors or X ContributorsTranslationsEspanolEtcEtc at the very beginning. Try with this song.
• You might also like in the middle of the lyrics. I saw that you already have some code to remove it, but mine doesn't seem to have the [0-9]+Embed at the end. Try with this song and look right before the outro.

UriParse return error when passing Map<String, int>

when we pass query as Map<String,int> the replace queryParamns returns error

according the document , query should be Map<String , String>