hayeah / fork2-rails Goto Github PK

Generally it's a nightmare to monkey patch the source of third-party libraries.

It makes future updates difficult.

In our case, we could simply make it work by adding the word counter, and using css to hide it. It's stupid, but it actually makes things simpler in the long run...

The class names you use now can very easily conflict with other rules.

.preview, for example, is too generic, and might be used in other places.

To learn how to architect css better, read scalable and modular css architecture. It's a short book, please read it.

Pay attention particularly to these 2 chapters:

• http://smacss.com/book/categorizing
• http://smacss.com/book/type-module

You could create a "css module" for the markdown editor.

The changes I'd make:

• change .editor to be .mdeditor
• change .preview to be .mdeditor-preview

The book explains why this naming pattern is good. (Also, you might also look at bootstrap to see what class names they give to components).