hawaii-desktop / qtaccountsservice Goto Github PK

Flesh out unit tests for the API.

• Test AccountsManager
• Test UserAccount
• Test QML

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This project was written when a lot of CMake stuff was not available and ECM was not usable.
These days we have nice macros to make libraries with config and generate camel case headers.

It will look much better if I can use some pre-built versions for Ubuntu 12.04 in sddm/sddm#439

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The UsersModel class introduce a hard-dependency on QtGui, we would probably split this addon in two libraries.

Classes are already documented, but we need to use Doxygen or whatever and create html documentation.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Make the API available to the QML world.

Run a static analyzer and fix all issues.

Review the API.

• Remove unnecessary API see #11
• The API needs to be completely async see #9
• The library should be called libQt5AccountsService.so - in order to make it parallel installable with a future Qt 6 based version; includes directory and cmake package should also be Qt5AccountsService

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I'm a bit concerned by the blocking calls in AccountsService here:
https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107

That has the potential to lock up the entire plasma workspace session; which obviously isn't ideal.
Blocking calls are a problem if we can't rely on the remote service /always/ behaving.