hassanhabib / prettyblazor Goto Github PK

Design could look like:

<Switch Evaluation="...">
   <Case Match="..."></Case>
   <Default></Default>
</Switch>

I realized that there are two different readme-files in this project. After forking the repository and cloning it onto my windows machine I got the following git warning:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'README.md'
  'readme.md'

The two files are not identical and have both been updated separately a few times. They should be merged into one file.

We started down the path of doing things like you are doing, but came up with a slightly different approach for the Iterator and Iterations... Essentially, we tried to keep as much of the razor tags as close to C# as possible. This implementation breaks one thing I like better about yours... and that is you have direct access to the object in the loop. With the below method,, one must understand you have an Item as well as an Index.

public class ComponentContext<T> where T : ComponentBase
{
    public ComponentContext(T @component) => Component = @component;
    public T Component { get; set; }
}

public class ForEach<T> : ComponentBase
{
    [Parameter]
    public IEnumerable<T> Items { get; set; }
    [Parameter]
    public RenderFragment<ForEachContext<T>> ChildContent { get; set; }

    protected override void BuildRenderTree(RenderTreeBuilder builder)
    {
        var index = 0;
        foreach (var item in Items)
            builder?.AddContent(0, ChildContent(new ForEachContext<T>(this, item, index++)));
    }
}

public class ForEachContext<T> : ComponentContext<ForEach<T>>
{
    public ForEachContext(ForEach<T> component, T item, int index) : base(component)
    {
        Item = item;
        Index = index;
    }
    public T Item { get; }
    public int Index { get; }
}

I've noticed that the Iteration component seems to be hardcoded to only take a List.

If an ICollection or IEnumerable is provided, for example, the error is also rather confusing.

Would it be possible to allow IEnumerable on the Items parameter? Or is there a specific reason why it has to be List?

Could we add a Virtualize option so that the Iteration component support lazy loading or maybe a different component all together. I would love to give this a shot

During development, I check for null reference pointer exceptions, i.e. from my Fluxor states, using the PrettyBlazor package.
This is not picked up by Visual Studio.
This does not register:

<Condition Evaluation="UserState != null">
    <Match>
        @UserState.Value.User.FullName
    </Match>
</Condition>

This does:

@if(UserState != null)
{
    @UserState.Value.User.FullName
}