harmony-one / explorer-v2-frontend Goto Github PK

Bug [Firefox]: Transactions table labels overlap with from address

when hitting this url => https://explorer.pops.one/address/0xe399d7504310b84d38efd56cf8a29b38801d6449 you get TypeError: Cannot convert undefined to a BigInt

see https://github.com/harmony-one/explorer-v2-frontend/blob/master/src/components/ui/OneValueDropdown.tsx#L48

Hi there,

I'm only able to see the last 100 transactions when I search my wallet address in the explorer (regardless of the records per page which I select). When I click the right arrow at the bottom, it says there's 'no data to display.' Not sure if this is a problem for others, but if so would you please try to fix this or advise what I'm doing wrong.

Thanks

instead of the time stamp saying "a day ago" it should have the actual date and time:

04/27/2021 20:48:17 PDT

The old explorer used to show the total number of transactions that took place in the contract which was a useful feature.

here are the txn hashes:

1. https://explorer.harmony.one/tx/0x0cdb5a8142f148ec7e955795901cf19665802c77c9f126b705c6079891dba5d6
2. https://explorer.harmony.one/tx/0x51c9b0c5eb37a1b8dba201a8efb6a6d6bab36eaa8ce7f11b77a6c4a6693600a7
3. https://explorer.harmony.one/tx/0xf7c27f0340cfd0ba7099e524c673790f8a644e54dd4a663c8fdf50db93c0be3d
4. https://explorer.harmony.one/tx/0x108de35ec308787ab78b73d229828020d5eb59e68582b3c278660dd4248b0373
5. https://explorer.harmony.one/tx/0x44a4e2099dc8bd5cc170b4cab7678d61f3751389edc4d70e7260557c0b4cf36f

those show 0 value on the explorer, but they had 1 ONEs

some contracts are deployed as proxies and there is a way to read/write via proxy to interact with such contracts in etherscan. we need this feature in our explorer. for example: https://etherscan.io/address/0x6a39909e805a3eadd2b61fff61147796ca6abb47#readProxyContract

Vyper smart contracts are second popular and currently the explorer only allows publishing solidity contracts. Some of the dapps like Curve have their contract source in vyper and needs this feature to verify their contracts.

Blockscout seems to have some feature: https://github.com/blockscout/docs/blob/master/for-users/smart-contract-interaction/verifying-a-smart-contract.md

Name, Symbol, total supply, inventory (all the good HRC721 stuff) not appearing.

https://explorer.harmony.one/address/0x9e8160b2ccb5335bc4183277e46e87d97fe49542?activeTab=0

Type
Feature

Problem
When scanning for an HRC20 Token it's often unclear, what token is a legitimately bridged token.

Example:

Why is this important
When creating a DAPP or swapping tokens, the malicious token address could be used and it will harm the users.

Possible Solution
Some kind of Token or Bridge indicator inside the explorer, that identifies the correct token.

Just like the old explorer.

Somehow looking at the number of ONE is better for my emotion than its value in USD.

Summary

Improve top level navigation options.

Problem

There currently is no way of finding Explorer functionality without knowing the "/ xEXAMPLEx" suffix.

Request

Create a menu bar with additional options beyond switching themes / address style and looking up specific token types (HRC20, HRC721, HRC1155)

Example

Etherscan has the following:

• "Home" (self - explanatory)
• "Blockchain" -- Menu options include: View Txns, View Pending Txns, View Contract Internal Txns, View Blocks, Forked Blocks, View Uncles, Top Accounts, Verified Contracts. NOTE: Currently, the most valuable options would be "Top Accounts", "Verified Contracts"
• "Tokens" -- self-explanatory
• "Resources" -- Most Valuable Menu Item includes such things as "Charts & Stats", "Top Statistics", "Developer APIs", Ethereum Directory, Explore dApps, Yield Farms and Airdrops
• "More" -- Includes a variety of tools for Developers, DeFi applications, Exploring and Tooling. Also very valuable.

WHAT HAPPENS:
Many users report seeing WONE in varying quantities in their wallet.

HOW TO REPRODUCE:
Goto any wallet in the Explorer, it may say it contains WONE, but if you check the WONE Explorer holders page https://explorer.harmony.one/address/0xcf664087a5bb0237a0bad6742852ec6c8d69a27a?activeTab=5
it says that they have none. This is also supported by connecting to any dex or adding the contract code to metamask.

As background, I've verified dozens of contracts without any issues before, but this one is giving me issues with bytecode not matching.

My recommendation would be deploying this file via Remix and attempting to verify it on the Harmony explorer:
https://github.com/FATEx-DAO/fatex-dex-protocol/blob/master/contracts/fatex/FateRewardControllerV2_flat.sol

I've made modifications to the original FateRewardControllerV2.sol file to exclude things that could cause the verifier to produce different bytecode, like:

• Arrays in constructors
• ABI Encoder V2
• Replace usages of implemented contracts as interfaces, (like RewardSchedule)
• Deploying with optimizations on and off, and attempting to verify the file with optimizations on/off

If you are able to deploy and verify it, can you please share what you did to do so and transfer ownership to the following address: 0x4853365bc81f8270d902076892e13f27c27e7266

It's not possible to open links in a new tab, for example clicking on an address or transaction will open the page in the same tab.

As a user I would like to open multiple transactions details and keep the overview open instead of continuously navigating back and forth in the same tab.

• only use https://harmony.one/brand fonts and color: nunito, grey not full black
• remove price under logo (duplicate display)
• have 4 siginficant digits for price
• 2x size of logo
• replace shard count by “transaction volume” (accumulated values of all transactions) like tx count
• on the front page, remove the little box “copy” icons under “latest transaction” on the top pages. it is cluttering up the front page. you can keep those on the txn detail pages.

Documentation: Update README for getting started with projectand Introduce Contributors.md for external contributors to project

Please add aUST to be recognized in Harmony's explorer views

The first test bridge transaction completed

• https://explorer.harmony.one/tx/0x20245896488f904068533f07f0d326160d8b1222a75ee688060b7bc0c47355cf?activeTab=0
• https://finder.terra.money/mainnet/tx/8C781FEF673D7B71C242BED3A9E8620C63F226BE3DC45BF3A4CE5BF0B019AD5E

can we make it easy for users to check their staked balance in a dex like sushi and viper using the explorer?

https://explorer.harmony.one/address/0x723f3c70a60191c52457e9802f5ec03b96302dd8

The Problem

Seems like most of the function calls on the Read Contract tab either 1) don't work or 2) don't display in the UI properly causing the UI to remain unchanged. Upon calling a read function, there is a brief progress bar that appears and disappears, and no data is shown in the UI where the progress bar was.

Upon checking the console, I couldn't see any network calls being made (the read call was done via web3 in a separate JS instance) nor any errors being logged.

The site also doesn't check that you're connected to the Harmony network before broadcasting a transaction. Meaning, you can accidentally be connected to Ethereum Mainnet and broadcast transactions.

What this contract is?

We just deployed a Multi Sig wallet to mainnet (shard 0) to get things rolling for our project.
Here's the link / wallet:

https://explorer.harmony.one/address/0x4853365bc81f8270d902076892e13f27c27e7266

Some important data to know:

• There is only one signer on the account : 0xCaCDaDe3AAa92582C3161ae5A9Fa3bB7e788FDF8
• There is only one executed transaction with ID 0.
• Using the Chrome web browser. It's updated to the most recent or one of the most recent versions.
• Putting it all together - the contract is properly initialized and has some state in it that would make querying doable

the previous explorer showed exact timestamp:

the current explorer shows relative time.

can we change the current explorer to show exact date and time. thank you!

The dropdown on the explorer says I have 88.777~ wONE HRC20 balance.

I believe this is a visual error. I have a tx receiving wONE from bossswap.finance, then I have a tx unwrapping the wONE:
tx1:https://explorer.harmony.one/tx/0x74a31c43ed1c8ff173668773ff700fab7239d380c25814007facb69f1eb56015
tx2:https://explorer.harmony.one/tx/0x72c2ceb4c2d3fbdea87f381241448001cb3d92af9d474a84c09b1469902034b2

I remember unwrapping and then using the ONE, so I don't think any ONE went missing.

Also, when I wrap a singular ONE now after this error appeared, the counter on the dropdown in explorer does not increment, it remains 88.777~, despite my wallet and dexes then showing the correct balance of 1 wONE.

You can contact me on discord at DirrtyPurpz#4021 if you need more details, otherwise thanks in advance.

Edit: here is the address for wONE I'm using, and the address found when I click through the dropdown in the explorer (to be sure it's not a fake/scam coin): 0xcf664087a5bb0237a0bad6742852ec6c8d69a27a

Windows 10 chrome metamask

currently it is off (should be taken from transaction's receipt)

Hello there!

I have been using the new harmony explorer for quite a while. It is quite an improvement over the previous iteration and helps in sorting out transactions types on a macro level.

I appreciate the fact that it is innovative and unique from other explorers. Thanks for making this update.

But it lacks a lot of analytical tools which are necessary for a token holder to access which are taken for granted on other well flourished networks like BSC and ERC.

Some small instance,

• For a wallet, filter HRC20 transfer by tokens on Harmony explorer.
• For a token, Pie chart of token holders giving in depth view on distribution.

Some ideas I can inculcate:

• Visual analytics of trading history of a token represented as a line graph. A point on the line graph representing the time and amount of traded token. In the current status, this feature is more DEX specific. If somehow the liquidity on Harmony chain can be unified on a single entity, it could be handy.

One bug I observed when I viewed the address in ETH address style, the token holder tab came out empty.

What is happening?

When visiting the HRC20 tab, only the first page of transactions is visible.
Pagination does not work.
However, you can see there are more txs by increasing the page limit to 100.

Expected Behaviour

Pagination should work for HRC20 tokens

Example

https://explorer.harmony.one/address/0xeb8fc2c39b8145b0860abda0df987719cbad29ca?activeTab=3

Please add a feature where you can see the holders of the token

Loading the chain-link deployed smart contracts are throwing exception:
Uncaught (in promise) TypeError: Cannot convert undefined to a BigInt

Example:
https://explorer.testnet.harmony.one/address/0xa0ABAcC3162430b67Aa6C135dfAA08E117A38bF0

This is most likely due to exceptions when trying to get token balances for the contract. It is happening in the testnet deploy

Address page should show rewards pending if validator or delegator and include that in an alternate account balance total. If not a validator/delegator, this can be hidden.

When reading a contract on the explorer, boolean values just show 'bool', but not true or false. It seems impossible to tell what it is set to. See here for an example: https://explorer.harmony.one/address/0xa678d193fecc677e137a00fefb43a9ccffa53210?activeTab=7

Example: https://explorer.harmony.one/tx/0x57c60f13b4a3149c4683112a97e8fb4144d8bb60524df68d8767451d06e99516

this is a simple native token ONE transfer, the gasUsed should be 21000, but displayed as 135168

It seems you treat 21000 as 0x21000=135168

api hmyv2_getTransactionReceipt returns decimals gasUsed, but your frontend parse it as hex number

Some community members have reported their transaction hashes returning as blank when searched on the harmony explorer. I am able to recreate that issue using chrome on mobile.

Example of a hash that appears blank:
https://explorer.harmony.one/tx/0x30bdbb31a79e61c76ff6e7a360be49c46fc9db7821021c3a10485eb1a12c89f1

The Read Contract feature seems incomplete or at least produces errors like:

Returned values aren't valid, did it run Out of Gas? You might also see this error if you are not using the correct ABI for the contract you are retrieving data from, requesting data from a block number that does not exist, or querying a node which is not fully synced.

For example, check the published contract: https://explorer.harmony.one/address/0xcf664087a5bb0237a0bad6742852ec6c8d69a27a?activeTab=7

Go to explorer
->
Go to contract
->
Go to write contract
-> renounce ownership transaction appears in metamask
-> if confirmed - contract is renounced within 2 seconds

Transaction page should show gasPrice in Gwei denomination and ordered on the transaction page:

Gas Limit
Gas Price
Transaction Fee / Cost

As to allow someone to easily see the multiplication of the first two fields into the last field.

Setup actions to run tests to validate PRs are safe to merge

Give a contributor issues a PR
When a PR is issued
Then a Action should be triggered to run a suite of tests to validate the PR is safe to merge

Setup conventional commit hooks to ensure

• Setup pre-commit hook to validate conventional commit
• Setup github action to validate conventional commit practice is followed

Release

• Ensure project follows semantic versioning

Smart contracts uses non-constant gas and we often have to validate if we set the right gas Limit. It would be useful to display gasUsed and gasLimit for a transaction.

Current displays:
https://explorer.harmony.one/tx/0x9acc20fa6894e6527283b4efaa4a0769887063f9a86c886dc2d157f1ee0fe048

When navigating back and forth between transactions the “records per page” always reverts back to 10.

As a user I would like to keep the state of the overview in the same position when navigating back and forth between address overview and transaction details.

What happens
Sometimes when I check a wallet, it results in a white screen.

Following error is thrown:

How to reproduce
This happens very inconsistently. The only idea I have is, that it's connected to heavily used wallets.
And some backend error occurs.

Explorer contract page: some write methods not working

https://explorer.harmony.one/address/0xd81c20ca3d9501cadbf861135c516e3d0ea599d6?activeTab=7

sentPrice method not working

The gasUsed property from API is 21,000, while the explorer shows 135,168.
Explorer Link:
https://explorer.harmony.one/tx/0xc6db64caa2ebfe0089ba02e4be80f39302e4d241351df0eb19619e756f7be653
Postman of hmyv2_getTransactionReceipt web method:

This is to track the long query inventory bounty in a branch PR.

Problem noticed around 12/30/21 @ 11am PST. Shows incorrect values for shard 0 block speeds - see image below

When moving from one transaction to another e.g. by search, the change on the site is so settle and fast, that the disappearing search is the only indicator that something happened, but you think in the first moment that something went wrong.

Similar to Etherscan we should show a thumbnail of the NFT in Explorer.

https://beta.explorer.harmony.one/tx/0xc7f8df678538cebf744233eb55a9fd50631689b374ed9f69548634f1791480aa?activeTab=1

Hello,

There is a small issue/improvement with the popup on the transaction history.
Right now the popup overlaps the graph, and so it is complicated to see the details for an other day.
Can we just display the popup just above the graph?
Thank you!