hardcpp / beatsaberplus

beatsaberplus's Issues

LevelStarted/LevelEnded events don't trigger automatically until they're manually triggered once

I've got a couple of events set up to automatically switch between a couple of OBS scenes depending on if I'm in the menu or playing a map. They won't automatically trigger until I manually trigger them once with the test button, after which point they work as expected. Occasionally leads to stuff like this happening.
https://www.twitch.tv/videos/1680963749?t=00h19m55s

Can’t see modules

So when I launched my beat saber with beatsaberplus installed, I clicked on it in the “Mods” area Ingame and none of the modules were there. Please help

Hide Song Chart Visualizer when UI is hidden

Hiding the UI via the checkbox in Player Options does not hide the chart. Can this be fixed? I'm happy to open a merge request if I have the time.

Song Info Bugs - Name Mismatch / Panel stuck inside leaderboard.

Unsure if this has already been reported elsewhere.

I've been unable to manually reproduce the name bug, but seemingly at random it will replace the name of a song in the list with another song. All other details remain correct.
With the panel misplacement, it seems there's like a 1 in 5 chance (more likely on the first time running after waking my computer from sleep) that when I start the game and go to the song list, the song details will be stuck inside the leaderboard and the only way to fix it is restarting the game.

I've included pictures of what this looks like.

Specs:
OS: Windows 10
CPU: Intel i5-10400F
GPU: AMD RX6750 XT
HMD: Quest 2
Connection: JSAUX Cable.
Game Version: 1.29.1 through Legacy Launcher.
BeatSaberPlus Version: 6.1.0

Chat requests eval text as hex, ignores leading zeros

Looks like you can request duplicate songs by leading with 0's.

Chat Alert module

[ ] test

Chat emotes do not show up in the game until the regular chat module is turned on once.

I prefer using Desktop+ for chat rather than having it in-game with BeatSaberPlus. I do like the emote rains BeatSaberPlus provides, but I have to toggle the chat module first.

https://www.twitch.tv/videos/1056951907?t=7m45s

Twitch chat not showing up in game

It seems like ChatCore is making the connection to my twitch channel alright, since !bsr populates the chat request queue, but messages posted in the chat don't appear in the in-game chatbox.

From my logs, I see errors like:

[ERROR @ 11:31:59 | BeatSaberPlus] An exception occurred in ChatMessageBuilder while parsing msg with 0 emotes. Msg: "asdf"
[ERROR @ 11:31:59 | BeatSaberPlus] System.NullReferenceException: Object reference not set to an instance of an object
[ERROR @ 11:31:59 | BeatSaberPlus]   at BeatSaberPlus.Modules.Chat.Utils.ChatMessageBuilder.PrepareImages (BeatSaberPlusChatCore.Interfaces.IChatMessage p_Message, BeatSaberPlus.Modules.Chat.Extensions.EnhancedFontInfo p_Font) [0x001b2] in <677367d7516a4c28a3ac0e48219da5f4>:0 
[ERROR @ 11:31:59 | BeatSaberPlus]   at BeatSaberPlus.Modules.Chat.Utils.ChatMessageBuilder+<BuildMessage>d__1.MoveNext () [0x00000] in <677367d7516a4c28a3ac0e48219da5f4>:0 

Some system info (lmk if anything else would be useful):

• BeatSaberPlus 2.0.12 (also saw the same behavior in 2.0.7)
• Ubuntu 20.04, running beat saber through Proton 5.13-4
• I'm using geefr's linux fork of BSIPA https://github.com/geefr/BSIPA-Linux

Song search/download support in Multiplayer+

It would be nice to have the ability to search for and download songs in a multiplayer+ lobby. this feature is available in the beat-together mod but not on multiplayer+.

Beatsaver requests causing twitch bans

I know this isn't directly, or solely, an issue with BeatSaberPlus, but someone has been going around and requesting a map which has something along the lines of "I am 9 years old" as a title, causing the request system to type the song name in chat, which is then reported by said person, causing bans.
It's very much a problem and might be able to fixed by adding some sort of filter to not put out text like that in chat, at least not automatically.
Preferably that filter should be enabled by default since otherwise it could affect to people who didn't know about the issue in the first place.
Thanks for your time!

Duplicate Follower Notifications

It's very easy for spammers to spam chat with "User is now following" messages and there's currently nothing streamers can do about it

Publish to https://beatmods.com

I wanted to install Multiplayer+ but was surprised to not see it in BeatSaberModManager. It isn't witchcraft to get it working of course (especially for the technologically able) but it'd still be more user-friendly to have the mods available in a package manager/mod manager.

Could you publish the core mod and the modules to https://beatmods.com?

Ideally all as separate mods with the modules depending on the core mod.

OT message to wiki maintainers

The installation instructions still list the old core mod name. It should be changed to ChatPlexSDK_BS.dll and perhaps mention that older versions had a different name. (The wiki isn't open to outside contributions or else I would have just edited it there.)

Song Request Suggestions - 'Delete' prompt on blacklist / Min Song Length / Manual Add To Queue

A couple hopefully simple but significant QoL ideas;

When blacklisting a song, which is usually after I've downloaded it to hear the preview, I usually also want to delete it, but I have trouble navigating the menus consistently to do so. It would be nice if, upon confirming a song blacklist, it also prompts asking 'Also delete song? Yes/No'

I find that a lot of meme songs are less than a minute long, or even a minute and a half. It would be nice to have the option to filter out songs below a certain length.

The only way to add something to the queue is to get the code of the map from beatsaver or DiTails, and manually request it in chat. It would be nice to have a button that directly adds the currently selected song to the queue.

[Request] Ability to add requests to queue via channel points?

I apologize if this is the incorrect way to go about making a request, but would it be possible to add songs to a queue via channel points? I see Channel Point integration is already a thing for other stuff, but really I'd like to do !bsr through channel points only instead of just the command if possible.

Thank you for your time.

multi+ download fails

fails if download takes too long

Add releases here on GitHub?

I was a little confused to see this repo didn't have any releases, and I couldn't find a dedicated download link. A viewer of my stream at the time then explained that I had to join the Discord server to download it, which I wasn't too happy to find out... I would appreciate it if you could make releases available here on GitHub, rather than only through the Discord chat room, so that players may be able to download it quickly without having to join a server. An added benefit of doing so is that you can automate messages on the Discord channel via webhooks!

• If you're planning on putting this mod on the Mod Assistant by the way, please feel free to disregard this request

Restarting a map prevents LevelEnded events from triggering

If I need to restart the map, I start the map over from the menu and avoid the Restart button in-game in order to have LevelEnded events trigger properly. If I use the Restart button, all LevelEnded events fail to trigger until I re-enter the map from the menu.
(forgot to clip this happening, sorry)

Allow changing countdown length in Multiplayer+

For me it's way too long. I usually play with like 1 other friend so we could use a lot shorter countdowns than they currently are.

Websocket Suggestions

There should be a way to know whether the user failed or finished a song. It could be possibly implemented via 2 additional events.

Additionally, there should also be a better method of telling whether the user soft failed rather than checking if the health is 0, like for example a bool in the scoreEvent.

Add compatibility for youtube live chat insted of just twitch.

The current version of multiplayer+ only supports twitch chat for song suggestions, you tube channel functionality would improve the experience for anyone who doesn't use twitch.