ui-assignment's Issues
Improper nesting of HTML elements
Again here
https://github.com/hamsakh/UI-Assignment/blob/master/shoppingcart.html#L62-L68
Links should be inside the li
not around it.
Also, It's better to separate the h3
from the ul
. It's the header to the link, doesn't belong to them
Use lowercase file names ...
Best practices say we should stick to lowercase file names ... Windows and Unix based systems deal with file names differently ... To avoid confusion, always use lowercase names for files
Improper nesting of HTML elements
https://github.com/hamsakh/UI-Assignment/blob/master/shoppingcart.html#L13-L31
Unordered lists can only contain list items .. You are inserting div
s and links directly inside the ul
. This HTML is invalid and will behave differently across the browsers.
Can you explain to me what are you trying to do here
https://github.com/hamsakh/UI-Assignment/blob/master/styles/styles.css#L91-L94
:)
We didn't discuss display: table
yet. What are you trying to do?
Use button instead of input type="submit"
https://github.com/hamsakh/UI-Assignment/blob/master/shoppingcart.html#L52
This help you avoid accidental selection of the input field using input { ... }
.
Use organized folder structure
Right now you there are images on the root directory .... Images should be collected inside one directory
Please pay attention to code indentation.
Use input type email
https://github.com/hamsakh/UI-Assignment/blob/master/shoppingcart.html#L51
Input type email force the browser to check the submitted string that it will be an email without using any third party library.
Subscription form input alignment
It's not centered on the design.
Width 100% with margin 0?
https://github.com/hamsakh/UI-Assignment/blob/master/styles/styles.css#L151-L155
These lines does nothing... margin auto i supposed to center the block within a container. It's already 100% wide so margin auto do nothing.
Using button instead of link
https://github.com/hamsakh/UI-Assignment/blob/master/shoppingcart.html#L38
This is supposed to be a link to a button. A button trigger an action or submit a form. Links link to other pages. This one is a link.
Use classes instead of IDs
The footer and the wrapper ... No need for them to be in an ID
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.