filter_fn default works across variants and effects about cohorts

[tavinathanson]

@arahuja so you're asking what happens if we have a filter specific for FilterableEffects and pass it into load_variants? I guess that wouldn't work, but why would we pass it in there? (Maybe some more examples that you're concerned about would help?) As for the reverse case (load_effects breaking because a field isn't in FilterableVariant), that should never happen since FilterableEffect extends FilterableVariant.

[arahuja]

so you're asking what happens if we have a filter specific for FilterableEffects and pass it into load_variants

Yes, just clarifying, this should not work then?

As for the reverse case (load_effects breaking because a field isn't in FilterableVariant), that should never happen since FilterableEffect extends FilterableVariant

Ah ok, didn't see this.

I guess my example is I have something like this:

def effect_gene_filter(filterable_effect):
    return filterable_effect.effect.gene_id in GENE_IDS

[tavinathanson]

Gotcha. Yeah, that shouldn't work and I assume will throw an error that FilterableVariant has no effect attribute. Does that seem reasonable?

[tavinathanson]

@arahuja can this be closed?