halfwhole / luminus-downloader Goto Github PK

My friend came across this rare problem where if the folder name contains forward slashes, the code breaks (on MacOS and Linux, not sure for Windows).

For example, a path on Luminus can look like this:
My Modules > PS2240 > Files > Tutorial Readings > Tutorial 1-Admin affairs/grouping/case discussion > Tutorial.pdf
'Tutorial 1-Admin affairs/grouping/case discussion' is a permissible folder name on Luminus.

However, when fs parses the path, the path looks like this: 'PS2240/Tutorial Readings/Tutorial 1-Admin affairs/grouping/case discussion', so the program thinks that 'grouping' and 'case discussion' are additional folders to be created.

More specifically, the code stops working at line 68 in downloader.js, when writeFile() call is made in downloadFolder().

Possible solutions:

1. Creating the folders locally, even though they don't exist on Luminus - possibly a hacky solution
2. Adding an additional check in parent folder 'Tutorial Readings' to check if sub-folders have slashes, and if they do, to replace them with some other character for Unix systems

Any ideas on how to resolve this?

For lacking directory_path in configuration settings, or for timeout.

Hi, just tried out this luminus-downloader (good stuff btw). I noticed that I was missing the yargs package even after npm install. This was solved by running an additional command in terminal to install it: npm i yargs. Maybe it would be good to add this to README.md under the "Running the script" section in case others encounter this issue? Cheers!

Backslashes in Windows paths screw up the downloaded .zip file, and so it can't be extracted properly. This also happens when you download the .zip file as a folder from LumiNUS directly; it gives the same bad result. Dammit, LumiNUS. 😡

Sigh, have to find some way to either write the downloaded buffer as a Unix-formatted .zip file, or convert it after it's been written.

No issues. Works incredibly well. Thanks for making this!