halfer / spiderling-utils

A PHPUnit/Spiderling utility to use Phantom in a headless test environment

I am currently looking for backend software work, senior level. Majoring in PHP or TypeScript, minoring in devops for all hosted CI platforms. I am UK-based and prefer fully/mostly remote. Please contact me through the platform you found me on. This README is intended to be a better summary of my work profile than a bare repo list. Most of my outside-work code is in private repos. Feedback welcome!

Stuff I've done 👨‍🏫 Currently volunteering as a coach at Codebar ✏️ I'm a 20K "Trusted User" and curator on Stack Overflow (1.5K answers & 117K edits) ⚙️ I've 2.6K posts to help folks with using CircleCI 🤖 I'm building an AI / ChatGTP-powered project with two product SMEs (all under wraps for now 🤐) 😇 I used to teach PHP in-person, and wrote this book-length tutorial

Code & experiments 🐑 They're not native to AWS, but I got PHP lambdas to work ↔️ I wrote a shared-hosting file sync system, which is in production use 🧪️ I did some experiments with Docker Swarm (39 ⭐) ⚗️ And here's another one

spiderling-utils's Issues

Get HHVM support working in Travis

I've tried adding hhvm to a branch in the Travis config, and it did not work. Here are the docs for the HHVM web server.

Possibilities:

• The server script needs to reference hhvm and not php
• The parameters to get the web server running seem to be different from the PHP ones

I don't need this right now, but am open to receiving PRs. The branch where this is started is hhvm-travis.

Add support for PHPUnit 6

PHPUnit 6 introduces namespaces to the test system, and specifies PHP 7.0 as a minimum version. PHPUnit Spiderling now has moved to support PHPUnit 6 only, so I can make use of that. However I am not ready to drop support for PHP 5 just yet, so I will see if I can support both.

A documentation update will be required here too.

A separate set of unit tests will need to be run in Travis, but only for PHP 7.0 and 7.1.

Handle non-Bash environments

The server.sh script has a hash-bang requiring Bash, which will not work in non-Bash environments. I could require there to be a shell command to prefix this script, or I could assume Bash is the default, and then try to detect it, and throw an error if it is not available and an alternative is not set.

Presently, I will just add a Server method to specify this.

For Server instances without a check-alive URL, perform a default check-alive

A Server without a check-alive will try to run tests before the server has had chance to stabilise:

php vendor/bin/phpunit 
PHPUnit 6.1.0 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 87 ms, Memory: 2.00MB

There was 1 error:

1) halfer\SpiderlingUtils\NamespaceDemo\SimpleTest::testAnything
Openbuildings\Spiderling\Exception_Curl: Curl: Download Error: Failed to connect to localhost port 8090: Connection refused, status 0 on url http://localhost:8090/

.../vendor/openbuildings/spiderling/src/Openbuildings/Spiderling/Driver/Simple/RequestFactory/HTTP.php:87
.../vendor/openbuildings/spiderling/src/Openbuildings/Spiderling/Driver/Simple.php:227
.../vendor/openbuildings/spiderling/src/Openbuildings/Spiderling/Driver/Simple.php:182
.../vendor/openbuildings/spiderling/src/Openbuildings/Spiderling/Driver/Simple.php:420
.../vendor/openbuildings/spiderling/src/Openbuildings/Spiderling/Page.php:33
.../vendor/openbuildings/phpunit-spiderling/src/TestCase.php:181
.../test/SimpleTest.php:14

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

As a result of this crash, the code to clean up the forked server does not run, and it persists until manually killed.

A default check-alive should be added to this, unless it is explicitly turned off.

Publish to Composer

This is good enough to unleash on the world now!

Redirecting web server stdout to /dev/null causes PhantomJS to exit early

I tried to apply this change to the web server:

diff --git a/src/scripts/server.sh b/src/scripts/server.sh
index c1b2d17..346bb57 100755
--- a/src/scripts/server.sh
+++ b/src/scripts/server.sh
@@ -30,7 +30,7 @@ PID_FILE=$3
 ROUTER_SCRIPT=$4
 
 # Start up built-in web server with router script
-php -S $SERVER_ADDR $DOC_ROOT $ROUTER_SCRIPT 2> $ERROR_FILE &
+php -S $SERVER_ADDR $DOC_ROOT $ROUTER_SCRIPT > /dev/null 2> $ERROR_FILE &
 
 # Let the server settle down
 sleep 1

However, this results in PhantomJS exiting early after a test, for reasons I just can't fathom, even after many hours of debugging.

What I am actually trying to fix is that in another repo, I am instantiating a server using Spiderling Utils, in order to run a browser test. The test fails (as expected) but I get this unexpected output:

Error when running server script: `PHP 7.0.28 Development Server started at Sun Mar 25 13:09:52 2018`

My redirecting stdout was an attempt to fix this, but it causes inexplicable problems in the tests here. I will try to fix this with a custom script for now, but I need to come back to this.

Add PhantomJS demo for PHPUnit 6

The small demo project for PHPUnit 6 only uses the simple driver, it would be good to exercise the phantomjs driver here too.

Add demo tests for PHPUnit 4 and 5

Now that #3 is essentially done, this will be easy - quick demos to be added to Travis.