Getting un catchable errors on non JSON files about json-machine

[halaxa]

I was just curious. You're right of course. The reason for this error is that the library is heavily optimized for performance thus ignoring some edge-case lexical errors, which a json token starting with capital P is. Those produce not very meaningful errors, such as yours. I'll look into handling such errors without hitting the performance.

[halaxa]

If I get it right, do you mean when you feed JSON Machine a compressed zip file? That's usually not what you want to do in the first place, right? :)

[flavinus]

No, this is not what I want in my application but this can happen because of user input file. Of course I will verify the file type before trying to parse it, but it could be interesting to improve robustness of your library (thanks it is very usefull :) )

[halaxa]

I'm failing to reproduce the error. Can you post the data or attach a failing test with this error? Place it in ParserTest please.

[halaxa]

Looking at it closer, the line
$tokenType = ${$token[0]};
you mention is not there since version 1.0.1. It was removed here eeb2051. That's why I haven't been able to replicate it in 1.1.1. The problem still persists as the Undefined array key error though. I'll look into it.

[halaxa]

Fixed on master. Check it out.

[halaxa]

Released in 1.1.2

[flavinus]

Thank you very much!!!
Sorry I was too busy and I didn't took time to help you for rproduction.

[halaxa]

No problem. I decided to early-release after the comment. I hope the unit test is enough. 😁 However feel free to reach out if you have any problems.