Coder Social home page Coder Social logo

Comments (4)

XedinUnknown avatar XedinUnknown commented on June 11, 2024

Seems to be connected to $iteratorLevel, which depends on the configured JSON pointers: no pointers - no path.

I don't know the codebase well, and so I wonder: perhaps, the $currentLevel needs simply to be greater than 0, and not depend on $iteratorLevel at all?

from json-machine.

XedinUnknown avatar XedinUnknown commented on June 11, 2024

Digging further, I understand why you probably wouldn't want the iterable to yield full paths as keys: each structure, including the top-most one, should probably have original keys, such that when converted to an array with e.g. iterator_to_array() it retains its key structure.
Also, it's trivial to wrap this into a generator that yields getCurrentJsonPointer() instead of keys, if this is what's needed.

So, currently the only problem with this is that apparently, when not specifying pointers, there's never any current path/pointer to retrieve. To my mind, the relationship between pointers and the path should not exist at all: the path should be available regardless of absence or presence of any pointers, because each value in a JSON document has a path.

from json-machine.

XedinUnknown avatar XedinUnknown commented on June 11, 2024

By the way, here's what I mean by wrapping Items in a Generator:

        // For each item, yield its full path instead of just the key
        return call_user_func_array(function (Items $data): Generator {
            foreach ($data as $key => $value) {
                $path = $data->getCurrentJsonPointer();
                // Path may be empty if all-matching pointer '' was specified
                // https://github.com/halaxa/json-machine/issues/105
                $newKey = !empty($path)
                    // Remove root prefix to make working with key easier, especially if top-level
                    ? ltrim($path, '/')
                    : $key;
                yield $newKey => $value;
            }
        }, [$data]);

from json-machine.

halaxa avatar halaxa commented on June 11, 2024

Tests of getCurrentJsonPointer() seem to be ok. Can you look at them and check your code for possible flaws?

from json-machine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.