hakeemmidan / jewely

An Etsy Inspired mock-marketplace that specializes in Jewelry

It is hard to avoid doing the hard, cool-looking thing, in favor of the easier, more timely, just-as-functional alternative

I try (if my ego permits) to go for the easier[, functional] solution whenever I recognize it

( ｡◕‿◕｡ )

Constructive feedback welcome at [email protected]

jewely's Issues

Project Proposal

Wiki Page Home

• Is the first page you see upon entering the wiki
• Contains a welcome message
• Contains a link/placeholder for a link to the live page
• All links in the right sidebar should contain each wiki page and link to the correct page
• Correctly formatted
  • each wiki page is listed in bullet points
  • all links route the correct page

Comments

---

MVP List

• Should have 7 MVPs.
  • 3 of those are User Auth, Heroku, and Production README.
  • The other 4 are from the MVP List or they have clarified them with you
• Contains a description sentence of the app
• Includes two to three detailed bullets on functionality and presentation of feature
• At least one CRUD feature, which states what CRUD operations are planned (creation, reading, updating, deletion)
• Estimates how long it will take the code each MVP
• Correctly formatted
  • MVPs are listed in an ordered list
  • Each MVP is broken down into bullet points

Comments

---

Database Schema

• Contains correct datatypes
• Contains appropriate constraints/details
  • primary key
  • not null
  • unique
  • indexed
  • foreign key
• Contains bullet points after the table that state which foreign keys will reference to which table, or references to the associations which will be made
  • foreign key and table name are lowercased, snake_cased and back_ticked
• Correctly formatted
  • schema is written in a table format
  • the table's name are lowercased, snake_cased and back_ticked
  • the table header column names are bolded
  • columns names are lowercased and snaked_cased and back_ticked

Comments

---

Sample State

• State shape is flat!
• State's keys are camelCased
• All keys within the values in the state are accessible in the schema
• Correctly formatted
  • Sample state is rendered with triple backticks, and the language ```javascript...```). This will display the state as a code block instead of a giant line of text
  • Top level slices
    • entities
    • session
    • errors (here or in ui)
    • ui (if needed)
  • Should NOT have nested slices, aka comments inside of posts
    • Some info from other tables is ok, for instance:
      • the author username and imageurl for a post. basically any info that the user can't change
      • like count and a boolean on whether the user likes the post instead of a likes slice

Comments

---

Backend Routes

• Contains the following sections: HTML, API Endpoints(Backend)
• Each route has a description
• API Endpoint routes contains wildcard variables written in snake_case
• Routes does not contain superfluous routes
• Have API routes that will allow the front end to get all info it needs and does not have unneeded routes:
  • probably doesn't need a GET likes api endpoint because that info comes through the post show

Comments

• Question: for the users index route, when would be a time where you'd need to get all users?

---

Frontend Routes

• Frontend routes contains wildcard variables written in camelCase
• Correctly formatted
  • Routes are displayed with inline coding text (backticks)

Comments

• On etsy.com their login and signup pages are modals and not direct frontend paths. It is up to your design choice if frontend routes for both are design choices you'd like to keep.

Product Seller Username Fetching Method

The product seller username tends to not instantly appear on screen in ProductShow. It takes some time to get fetched. This results in a 'wonky' looking product show page.

It may be better to attach the seller username to each product in backend (rather than fetching user for each product in frontend).

This could be achieved in same way that we attached author_username to each review. That is:

1. Create column for seller_username
2. Allow it in both model and controller through validations and params (respectively)
3. Attach seller_username to each product through create action in controller
4. Extract it using JSON JBuilder
5. Show it in frontend

Readme Update

Readme needs to be updated to reflect new changes in website

Search Bar

There needs to be a search bar in home page.

It should:

• Filter out result based on product name and description
• Only be available when ProductsIndex is showing