hackerone / curl Goto Github PK

View Code? Open in Web Editor NEW

54.0 54.0 72.0 381 KB

Curl wrapper for Yii framework

PHP 100.00%

curl's People

Contributors

Stargazers

Watchers

Forkers

raykwok suhanda sleepdragon lmagalhaes doelrb willieroque pawl ergoz santik jimorillo dariospadoni lincolnliu zdamasyi darussalamtech ptheofan for2ne mihailshumilovsms mauro-moreno yht0616 atuxe norbit24 taohs buildsufai liangxiaobo heartshare bingeng tpruvot sanchezzzov bodyanuk 9zigen sannek8552 leandemon nikoniu uniconstructor dlinny waleoyediran xuchunhe yoopea suriyabaskaran liuwei2324 stapostol tuandat1992 aliefchandra pinguo-liwei jerrylsxu selimppc lijin007 udeth vldmr-k johndarylsirps steelray shyevsa im286er mrccao shijiaoliang boynanboy hehe24h phphunter williamtse shijiaoliang1989 nguyenlam206 dataxang yuriefin xxw2016 muknepooja guoyu07 allpereira georgezim85 time-travelers josejlpp kyawsawdin

curl's Issues

wrong settings merge

must be $this->options + $this->_config to allow rewrite default $_config options for example
'curl' => array(
'class' => 'ext.Curl',
'options' => array(
CURLOPT_FOLLOWLOCATION => (!ini_get('open_basedir') and !ini_get('safe_mode')) ? true : false,
),
),

Error sending array through POST

Hello
There was a problem with the method of POST, when I send an array of error takes off.
Helps formatting data to be sent via function http_build_query


public function post($url, $data, $params = array(), $debug = false)
{
        $url = $this->buildUrl($url, $params);
        $options = $this->getOptions();
        $options[CURLOPT_POST] = true;
        $options[CURLOPT_POSTFIELDS] = is_array($data) ? http_build_query($data) : $data;
        return $this->exec($url, $options, $debug);
}

you forgot finish addHeader function

public function addHeader($header = [])
{
    $h = $this->request_options[CURLOPT_HTTPHEADER] ? $this->request_options[CURLOPT_HTTPHEADER] : [];
    foreach($header as $key => $val){
        $h[] =
    }

    $this->request_options[CURLOPT_HTTPHEADER] = $h;
}

curl_close problem

code:

// initialize curl
public function init(){
    try{
        $this->_ch = curl_init();
        $options = is_array($this->options)?array_merge($this->_config,$this->options):$this->_config;
        $this->setOptions($options);

        // close curl on exit
        Yii::app()->onEndRequest = function(){
            curl_close($this->_ch);
        };
    }catch(Exception $e){
        throw new CException('Curl not installed');
    }
}

have a problem near "curl_close($this->_ch);" and throw php fatal error - "Using $this when not in object context". I replace it to:

public function init(){
    try{
        $this->_ch = curl_init();
        $options = is_array($this->options)?array_merge($this->_config,$this->options):$this->_config;
        $this->setOptions($options);
        $ch = $this->_ch;

        // close curl on exit
        Yii::app()->onEndRequest = function() use(&$ch){
            curl_close($ch);
        };
    }catch(Exception $e){
        throw new CException('Curl not installed');
    }
}

and everything became working fine. please fix.

adding follow_location emulation

do it for self


private $_config = array(
    CURLOPT_HEADER => true,
    CURLOPT_FOLLOWLOCATION => false,
    ...
}
private $follow_location = false;    

private function canFollow() {
        return (!ini_get('open_basedir') and !ini_get('safe_mode'));
}

public function follow($follow) {
    $this->follow_location = $follow;
    return $this;
}

private function _exec($url){
       $this->setOption(CURLOPT_URL, $url);

       # redirects
       if($this->follow_location) {
        if($this->canFollow()) {
             $this->setOption(CURLOPT_FOLLOWLOCATION, true);
        }
    else {
        $this->setOption(CURLOPT_FOLLOWLOCATION, false);
    }
       }

    $response = curl_exec($this->_ch);
    $header_size = curl_getinfo($this->_ch, CURLINFO_HEADER_SIZE);
    $header = mb_substr($response, 0, $header_size);
    $content = mb_substr($response, $header_size);

    # redirects
    if($this->follow_location) {
        $http_code = curl_getinfo($this->_ch, CURLINFO_HTTP_CODE);
        if(in_array($http_code, array(301, 302, 303))) {
            if(preg_match('/Location: (.+?)\n/', $header, $matches)) {
                $url = trim($matches[1]);
                return $this->_exec($url);
            }
        }
    }

    if(!curl_errno($this->_ch))
        return $content;
    else
        throw new CException(curl_error($this->_ch));
}

    public function getRealUrl($url) {
        $this->follow(true);
        $this->setOption(CURLOPT_URL, $url);
        $this->setOption(CURLOPT_NOBODY, true);
        $this->setOption(CURLOPT_FOLLOWLOCATION, false);
        $header = curl_exec($this->_ch);
        if(preg_match('/Location: (.+?)\n/', $header, $matches)) {
            $url = trim($matches[1]);
            return $this->getRealUrl($url);
        }
        return $url;
    }

Missing port number on GET

Hi, thank you for your job,
it seems like builUrl() doesn't add port number (if specified) while returning the URL.

Row 83:
return $parsed['scheme'].'://'.$parsed['host'].$parsed['path'].$parsed['query'];

getHeaders() returns wrong data

on my configuration $curl->getHeaders() returns wrong data.

this is happens because in $this->response (where you are storing response data)
contained something like this:

HTTP 100 Continue
\r\n\r\n
HTTP 100 Continue
\r\n\r\n
HTTP 200 OK
<..other headers..>
\r\n\r\n
<..body..>

solution is to rewrite getHeaders as following:

$responseEntries=explode("\r\n\r\n",$this->response);
$countRE = count($responseEntries);
$headerText = $responseEntries[$countRE-2];
$headers     = array();
foreach (explode("\r\n", $headerText) as $i => $line) {
   if ($i === 0) {
    $headers['http_code'] = $line;
   } else {
    list ($key, $value) = explode(': ', $line);
    $headers[$key] = $value;
   }
}
return $headers;

Notice "Undefined offset: 42" in protected/extensions/curl/Curl.php(32) when CURLOPT_HEADER option not set in extension config

Screen http://joxi.ru/GxW0UxjKTJCvNZQ0RYo

Options:

        // Curl wrapper extension
        'curl' => array(
            'class' => 'ext.curl.Curl',
            'options' => array(
                /**/
            ),
        ),

There is no composer.json

When I try to add this library with composer, I get:

  [Composer\Repository\InvalidRepositoryException]                                                                                   
  No valid composer.json was found in any branch or tag of https://github.com/hackerone/curl.git, could not load a package from it.

Curl wrapper library and Elasticsearch

Sending GET request with array to ES gives error. Unpleasant problem

Unsupported operand types Curl.php(88)
$params = (isset($parsed['query']) ) ? $data + $parsed['query'] : $data;

https://discuss.elastic.co/t/query-string-with-range/85111

_isAssoc method doesn't exist

public function setHeaders($header)
    {
        if($this->_isAssoc($header)){
            $out = array();
            foreach($header as $k => $v){
                $out[] = $k .': '.$v;
            }
            $header = $out;
        }
        $this->setOption(CURLOPT_HTTPHEADER, $header);
        return $this;
    }

The method _isAssoc does not exist.

hackerone / curl Goto Github PK

curl's People

Contributors

Stargazers

Watchers

Forkers

curl's Issues

wrong settings merge

Error sending array through POST

you forgot finish addHeader function

curl_close problem

adding follow_location emulation

Missing port number on GET

getHeaders() returns wrong data

Notice "Undefined offset: 42" in protected/extensions/curl/Curl.php(32) when CURLOPT_HEADER option not set in extension config

There is no composer.json

Curl wrapper library and Elasticsearch

_isAssoc method doesn't exist

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent