hachi8833 / gelo Goto Github PK

A VM is not allowed to write to its parents's namespaces, removing an item from 
a namespace cannot fail. So at present if you attempt to delete an item owned 
by a parent the only recourse is to crash. Solution: Each vm shall have  a 
"black list" set (a map[string]bool, created only if used) that such deletions 
can be recorded in and future namespace lookups fail if the searched name is in 
the blacklist.

gelo/commands/argparse.go needs unit tests

gelo/interpreter.go needs unit tests

gelo/list.go needs unit tests

gelo/util.go needs unit tests

When run on rpn.lit, the buffer gets jammed at the end and discharges its final 
contents ad infinitium.

It was necessary until we made util.go:recordingReader but now it is dead code 
but it could still be used easily for pretty printing, but that does not  seem 
to be something that should be included in what is supposed to be a lightweight 
core and it would have to remain in core since it has knowledge of unexported 
fields. However, it would not be linked unless used.

This code is very messy. Need to refactor the [junk => junk|otherwise junk] 
matcher out of case-of so it can be used for other control structures.

Change all code in commands/* that builds list by hands to use ListBuilder

gelo/commands/math.go needs unit tests

gelo/commands/combinator.go needs unit tests

Currently, nested {} get escaped, but as long as they balance this is 
unnecessary and overly annoying.

gelo/commands/list.go needs unit tests

What steps will reproduce the problem?
1. cd gelo/src
2. make

What is the expected output? What do you see instead?
Expected: a compiled binary of gelo and associated gelo tools.
Instead:
[russ@myhost src]$ make
cd gelo; make install
make[1]: Entering directory `/home/russ/repos/gelo/src/gelo'
/home/russ/bin/6g -o _go_.6 parser.go interpreter.go vm.go api.go namespace.go 
trace.go types.go port.go list.go dict.go sym.go bool.go number.go quote.go 
error.go builtins.go util.go 
rm -f _obj/gelo.a
/home/russ/bin/gopack grc _obj/gelo.a _go_.6 
cp _obj/gelo.a "/home/russ/repos/go/pkg/linux_amd64/gelo.a"
make[1]: Leaving directory `/home/russ/repos/gelo/src/gelo'
cd gelo/extensions; make install
make[1]: Entering directory `/home/russ/repos/gelo/src/gelo/extensions'
/home/russ/bin/6g -o _go_.6 stdio.go listbuilder.go argparse.go 
rm -f _obj/gelo/extensions.a
/home/russ/bin/gopack grc _obj/gelo/extensions.a _go_.6 
cp _obj/gelo/extensions.a 
"/home/russ/repos/go/pkg/linux_amd64/gelo/extensions.a"
make[1]: Leaving directory `/home/russ/repos/gelo/src/gelo/extensions'
cd gelo/commands; make install
make[1]: Entering directory `/home/russ/repos/gelo/src/gelo/commands'
/home/russ/bin/6g -o _go_.6 all.go eval.go argparse.go names.go control.go 
types.go port.go string.go dict.go math.go list.go logic.go copy.go 
combinator.go io.go regexp.go error.go util.go
rm -f _obj/gelo/commands.a
/home/russ/bin/gopack grc _obj/gelo/commands.a _go_.6 
cp _obj/gelo/commands.a "/home/russ/repos/go/pkg/linux_amd64/gelo/commands.a"
make[1]: Leaving directory `/home/russ/repos/gelo/src/gelo/commands'
cd tools; make install
make[1]: Entering directory `/home/russ/repos/gelo/src/tools'
6g gelrun.go
6g geli.go
geli.go:104: history.Iter undefined (type vector.StringVector has no field Iter)
geli.go:105: typechecking loop
geli.go:244: lines.Iter undefined (type vector.StringVector has no field Iter)
geli.go:245: typechecking loop
geli.go:256: (&history.*StringVector·Slice(_make_slice(vm, "see", args))).Iter 
undefined (type vector.StringVector has no field Iter)
geli.go:257: typechecking loop
geli.go:402: acc.Data undefined (type vector.Vector has no field Data)
geli.go:412: typechecking loop
geli.go:463: r.lines.Iter undefined (type vector.StringVector has no field Iter)
make[1]: *** [all] Error 1
make[1]: Leaving directory `/home/russ/repos/gelo/src/tools'
make: *** [tools] Error 2
[russ@myhost src]$ 

What version of the product are you using? On what operating system?
rev.8e61802f62; Archlinux 2010.05 amd64 with go a874585a5d2e tip.

Please provide any additional information below.
In order to get it to compile, had to modify the makefiles to make them more 
crossplatformy. Attached the patch for the makefiles.

Also hacked the code a bit to get it to compile with some unclever alternative 
lines of code but the only example that seems to produce any output is 
syntax.gel. The turtle examples work just fine with my "fixes". Attached a 
patchfile for those fixes as well for review.

What steps will reproduce the problem?
1. go get code.google.com/p/gelo

What is the expected output? What do you see instead?

It should install gelo. It fetches it, but doesn't install; gelo is not 
organized to be goinstallable.

What version of the product are you using? On what operating system?

Go version 1

builtins.go needs unit tests

Currently even the most informative error messages give no hint as to origin.

Parser needs to keep track of line numbers

api.go needs unit tests

What steps will reproduce the problem?
1. get last stable go release
2. download gelo
3. run make

What is the expected output? What do you see instead?

expected compilation goes fine (not really, because project seams to be 
outdated), And got error:

$ make
cd gelo; make install
make[1]: Entering directory `/tmp/gelo/src/gelo'
8g -o _go_.8 parser.go interpreter.go vm.go api.go namespace.go trace.go 
types.go port.go list.go dict.go sym.go bool.go number.go quote.go error.go 
builtins.go util.go 
interpreter.go:189: cannot use multiple-value assignment for non-blocking 
receive; use select
vm.go:40: cannot use multiple-value assignment for non-blocking receive; use 
select
port.go:17: cannot use multiple-value assignment for non-blocking receive; use 
select
make[1]: *** [_go_.8] Error 1
make[1]: Leaving directory `/tmp/gelo/src/gelo'
make: *** [pkgs] Error 2

gelo/commands/string.go needs unit tests

The current code for the arg parser is messy and disorganized. Passes an entire 
object around that when only one map is required and said map could be made 
part of the match type.

gelo/vm.go needs unit tests

Currently trace and error have their own subtly different but essentially 
identical mechanisms for formatting gelo objects. These should be replaced by 
satisfying the stringer and gostringer interfaces for internal types and 
whatever whosits lie in fmt. This would clean up a lot of internal code but 
should not affect functionality unless as a by-product a cleaner way of 
presenting data arises.

gelo/parser.go needs unit tests

gelo/commands/dict.go needs unit tests

gelo/namespace.go needs unit tests

Should we not use defer for passing arguments. It would allow us to do more, 
but we would need to keep track of a great deal more data, especially during 
recursion, that at present we are happily offloading on to the go call stack.

There is common functionality that may deserve to be factored into a new 
sub-package. At the very, least they should be broken up into multiple files.

It will never be truly safe until we can banish dastardly names from its 
reaches.

gelo/dict.go needs unit tests

gelo/commands/control.go needs unit tests