h6ah4i / android-tablayouthelper

A small library which helps to use TabLayout with ViewPager more easily.

android-tablayouthelper's Issues

onTabReselected() callback is called when clicking not selected tab

Attempt to invoke virtual method 'int android.widget.LinearLayout.getChildCount()' on a null object reference

android-tablayouthelper/library/src/main/java/com/h6ah4i/android/tablayouthelper/TabLayoutHelper.java

Line 378 in 7163716

int childCount = slidingTabStrip.getChildCount();

I occasionally get this exception on production:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'int android.widget.LinearLayout.getChildCount()' on a null object reference
at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.determineTabMode(TabLayoutHelper.java:378)
at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.adjustTabModeInternal(TabLayoutHelper.java:412)
at com.h6ah4i.android.tablayouthelper.TabLayoutHelper$5.run(TabLayoutHelper.java:303)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6942)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

As a dirty fix I am subclassing TabLayoutHelper and overriding determineTabMode:

public class TabLayoutHelperFixed extends TabLayoutHelper {
	@Override
	protected int determineTabMode(@NonNull TabLayout tabLayout) {
		try {
			return super.determineTabMode(tabLayout);
		} catch (NullPointerException e) {
			return TabLayout.MODE_FIXED;
		}
	}
}

Need to add consumer Proguard settings

App crashes if Proguard is enabled. Add the following line to proguard-rules.pro.

-keepclassmembernames class android.support.design.widget.TabLayout { *; }

Adjust to ViewPager2

Can you please add support for the ViewPager2-class?

Any further development planned?

I don't know if it's possible, but I have some ideas. ;-)
How about to add badges to tablayout or make the tablayout/viewpager not swipeable,...

Failed to resolve: com.h6ah4i.android.tablayouthelper:tablayouthelper:0.6.1

I'm not sure why, but i can't get this library from jcenter

need proguard setting.

need proguard setting.

-keep class android.support.design.widget.TabLayout {
    private OnClickListener mTabClickListener;
    private float getScrollPosition();
}

because private access.

static {
      mGetScrollPosition = getAccessiblePrivateMethod("getScrollPosition");
      mTabClickListener = getAccessiblePrivateField("mTabClickListener");
}

About a question from android 5&6

HI , I use The latest version of 1.0.0
in my crashlytics log send this crash

Fatal Exception: java.lang.NullPointerException
Attempt to invoke virtual method 'int com.google.android.material.tabs.TabLayout.getTabMode()' on a null object reference
com.h6ah4i.android.tablayouthelper.TabLayoutHelper.adjustTabModeInternal

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'int com.google.android.material.tabs.TabLayout.getTabMode()' on a null object reference
at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.adjustTabModeInternal(TabLayoutHelper.java:407)
at com.h6ah4i.android.tablayouthelper.TabLayoutHelper$5.run(TabLayoutHelper.java:303)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:179)
at android.app.ActivityThread.main(ActivityThread.java:5650)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:791)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:681)

this problem only on the android 5&6 how can i fix this bug?

thank

Compatibility issue with support library 28.0.0-beta01

After updating our application from Android support library from version 27.1.1 to version 28.0.0-beta01 the application now fails to start (to test compatibility on a Pixel 2 with Android P and target SDK 28)

We see the following error on startup:

E/UncaughtException: java.lang.NoSuchMethodError: No virtual method addOnTabSelectedListener(Landroid/support/design/widget/TabLayout$OnTabSelectedListener;)V in class Landroid/support/design/widget/TabLayout; or its super classes (declaration of 'android.support.design.widget.TabLayout' appears in /data/app/<app-name>/base.apk)
        at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.setupWithViewPager(TabLayoutHelper.java:327)
        at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.<init>(TabLayoutHelper.java:98)

The crash happens here:

protected TabLayout.OnTabSelectedListener mInternalOnTabSelectedListener;

tabLayout.addOnTabSelectedListener(mInternalOnTabSelectedListener);

So it seems this library is no longer compatible with support library version 28

Compatibility issue with support library 23.0.0

Not switching the pager contents when clicking a tab.

1. Add some tabs
2. Swipe and change the current page
3. Click an inactive tab

IncompatibleClassChangeError

This crash happens when change tab

java.lang.IncompatibleClassChangeError: Class 'com.h6ah4i.android.tablayouthelper.TabLayoutHelper$2' does not implement interface 'com.google.android.material.tabs.TabLayout$BaseOnTabSelectedListener' in call to 'void com.google.android.material.tabs.TabLayout$BaseOnTabSelectedListener.onTabUnselected(com.google.android.material.tabs.TabLayout$Tab)' (declaration of 'com.google.android.material.tabs.TabLayout$1' appears in /data/app/com.truted-rUEWL7WfVvhr2YMKi3Y1jg==/split_lib_dependencies_apk.apk) at com.google.android.material.tabs.TabLayout$1.onTabUnselected(TabLayout.java:788) at com.google.android.material.tabs.TabLayout.dispatchTabUnselected(TabLayout.java:1736) at com.google.android.material.tabs.TabLayout.selectTab(TabLayout.java:1720) at com.google.android.material.tabs.TabLayout$TabLayoutOnPageChangeListener.onPageSelected(TabLayout.java:2967) at androidx.viewpager.widget.ViewPager.dispatchOnPageSelected(ViewPager.java:1947) at androidx.viewpager.widget.ViewPager.scrollToItem(ViewPager.java:686) at androidx.viewpager.widget.ViewPager.setCurrentItemInternal(ViewPager.java:670) at androidx.viewpager.widget.ViewPager.onTouchEvent(ViewPager.java:2263) at android.view.View.dispatchTouchEvent(View.java:12540) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3153) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2829) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3159) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2844) at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:601) at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1871) at android.app.Activity.dispatchTouchEvent(Activity.java:3384) at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69) at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69) at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:563) at android.view.View.dispatchPointerEvent(View.java:12788) at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:5675) at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:5470) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4963) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5016) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4982) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5119) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4990) at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5176) 2019-01-18 23:53:40.819 16656-16656/com.truted E/AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4963) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5016) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4982) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4990) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4963) at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:7742) at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:7682) at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:7643) at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:7853) at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:197) at android.os.MessageQueue.nativePollOnce(Native Method) at android.os.MessageQueue.next(MessageQueue.java:325) at android.os.Looper.loop(Looper.java:142) at android.app.ActivityThread.main(ActivityThread.java:6944) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

Attempt to invoke virtual method 'void android.view.View.setSelected(boolean)' on a null object reference

Hi, I updated sdk version to 24, and appcompat to v7:24:0:0 and design:24:0:0 and launched app, and app crashed:

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setSelected(boolean)' on a null object reference at android.support.design.widget.TabLayout$Tab.setCustomView(TabLayout.java:1298) at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.onUpdateTab(TabLayoutHelper.java:204) at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.updateTab(TabLayoutHelper.java:351) at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.setTabsFromPagerAdapter(TabLayoutHelper.java:323) at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.setupWithViewPager(TabLayoutHelper.java:302) at com.h6ah4i.android.tablayouthelper.TabLayoutHelper.<init>(TabLayoutHelper.java:90) at com.my.app.MainActivity.onCreate(MainActivity.java:100) at android.app.Activity.performCreate(Activity.java:6092) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1112) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2468) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2595)  at android.app.ActivityThread.access$800(ActivityThread.java:178)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1470)  at android.os.Handler.dispatchMessage(Handler.java:111)  at android.os.Looper.loop(Looper.java:194)  at android.app.ActivityThread.main(ActivityThread.java:5624)  at java.lang.reflect.Method.invoke(Native Method)  at java.lang.reflect.Method.invoke(Method.java:372)  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:959)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:754) 

my.app.MainActivity

100. TabLayoutHelper mTabLayoutHelper = new TabLayoutHelper(tabLayout,viewPager); 101. mTabLayoutHelper.setAutoAdjustTabModeEnabled(true);
If i change sdk version to 23 and AppCompat to v7:23:7:0: and design to 23:7:0 , all works