h5p / h5p-accordion

Accordion content type for H5P

H5P Accordion

Accordion content type for H5P

License

(The MIT License)

Copyright (c) 2015 Joubel AS

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

h5p-accordion's Issues

Ability to Open Multiple Accordions at Once

It would be nice to be able to open more than one so that one does not automatically close when another is selected. This would be especially useful if you want to print a page so that all tabs could be opened and all hidden content would be viewable offline.

Accessibility issue in keyboard nabigation

We are teh KOMPETENZZENTRUM DIGITALE BARRIEREFREIHEIT.NRW, we are a digital Accessibility evaluation and testing organization within the Technical University of Dortmund, Germany. We have scientifically evaluated the Accessibility of different H5P elements including Accordion, and we have observed the following points.

• "The problem with the accordions on the H5P side is the focus management for the accordion headings. Normally, the buttons should only catch Enter and Return (and show/hide the sections). In H5P, they also catch the arrow keys, but this is not actually intended (see ARIA Authoring Practices Guide).

Solution 1: Stop intercepting the arrow keys. Then the arrow keys are used for scrolling.
Solution 2: Make sure that there is always a focusable element in the displayed content (e.g. a heading with tabindex="0"). This can also be the entire section (tabindex="0" on a section element), but only if it contains no focusable content.
Solution 3: Consider scrollbars. This could still be a bit fiddly for keyboard-only (without a screen reader)."

ability to add subcategories

Hello,

At the moment you can only specify one title and text meaning that you can only make one category but not subcategories for that current title. I would like to see a ability to create subcategories/titles f.ex;

Title1
text1
 Title 1.1
  text1.1
   Title 1.1a
    text 1.1a
 Title 1.2
  text 1.2 
Title2
text2
Title3
text3

Accordion Type non-heading option (accessibility issue)

Currently the Accordion content type editor has options for creating H2, H3, and H4s for the accordion toggles.

There should also be an non-heading option such as P or SPAN. When an accordion is inserted into a page of content, the heading will often break the surrounding document structure (i.e. the heading sequence), inserting a heading where none is expected. Sometimes the author can predict where the accordion will be placed, and guess which heading to use so it fits the heading sequence on the page of content.

Other times, maybe most times, like in the middle of a section of content made up of several paragraphs, that say starts with an H2, plugging an accordion following the first paragraph in that section, and selecting an H3 in the accordion editor, it would fit the sequence after the H2 for that section, but then that H3 becomes a heading for the paragraphs that follow, which structurally are still children of the section's H2 heading. This will create confusion for some screen reader users. Currently the only place the accordion can be placed safely, without breaking the document structure, is at the end of a section, or the end of a page.

Screenshot of the accordion heading selector

By providing a non-heading option for the accordion, it gives the content author the option of placing the accordion anywhere in the content, without affecting the document structure.

Feature Request: Text block above the accordion

Having a text block above the accordion would look clean and allow a person to introduce the accordion.

EXAMPLE:

Feature request: ability to add a image/s

Hello,

I Would like to see an feature in Accordion that lets you insert/embed images to the text-field.

font size for titel of panel are not rendered corretly

The setting of the font size (h2, h3 or h4) for the title of the panel is adopted. However, all three font sizes are rendered in the same size.

Here are some example screenshots:

Thanks a lot for the awesome work.