System.Reflection.AmbiguousMatchException with component functions that have multiple signatures about unium

[gwaredd]

Done.

In the event there are multiple functions with the same number of arguments it'll call the first one. Acceptable?

[gwaredd]

Under-the-hood it's a Type.GetMethod(string) call, which throws if there are multiple methods with the same name.

It could potentially be a bit more clever and try to match the arguments in the query to a function signature. However, as this would be trying to match strings with underlying types there will always be some ambiguity (e.g. is "123" an int or a float?). It will also be slower and move convoluted code.

The most expedient solution is to rename the functions or add a test hook that shims the underlying implementation. If you think there is a strong case for unium handling some of the ambiguity I'll give it some consideration ;)

[bryandickson]

Thanks. I’m going to have to write my own wrapper function. To complicate things further, the component function I want to use is from a plugin prefab, and it provides only async/Task or callback functions. Any recommendations there?

…

Sent from my iPhone

On Apr 20, 2021, at 2:50 AM, Gwaredd ***@***.***> wrote:  Under-the-hood it's a Type.GetMethod(string) call, which throws if there are multiple methods with the same name. It could potentially be a bit more clever and try to match the arguments in the query to a function signature. However, as this would be trying to match strings with underlying types there will always be some ambiguity (e.g. is "123" an int or a float?). It will also be slower and move convoluted code. The most expedient solution is to rename the functions or add a test hook that shims the underlying implementation. If you think there is a strong case for unium handling some of the ambiguity I'll give it some consideration ;) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[gwaredd]

If you're working with async code take a look at UniTask.

Unium can invoke UniTask functions as normal, the query will then exit and the functions will execute asynchronously. This means the results aren't returned to the query but you can all the functions, which may be good enough for some things.

If you want the results returned in the query then there is some work to do. There's various ways to do this with varying degrees of effort and elegance.

[gwaredd]

Alternatively you use callbacks to raise an event if you are using websockets.

[lacostej]

We are hitting this as well.

If we were to improve the heuristic to only find the method that has the same number of parameters, in the case there is only one, would that be an acceptable change? It would have a limited performance impact and increase the amount of supported cases

[Ekareya]

The use case that @lacostej and me are hitting is on this function :
https://docs.unity3d.com/2019.3/Documentation/ScriptReference/Camera.WorldToScreenPoint.html
which have two different methods.
In my use case, to Automate some test, I am using Unium as the "eye" and Appium as the "hand", so this function is a must-have,

Anyway, in the meantime, I've patched it locally on my own by checking for the number of methods signatures and using getMethod(string,Type[]) instead for the relevant case.
I am getting my Type[] from the members parameters that have the right number of parameters and throwing an exception if I find multiple parameters signature with the same number or parameters.

It solves my issue with WorldToScreenPoint(), but it's not a catch-all as it still leaves out the case where you have more than one method with the same number of arguments.