gurashish1singh / initial_setup Goto Github PK

if [[ $(command -v poetry) ]]; then

The above conditional to check if poetry is installed to the user's path in the shell script, setup.sh only works for GitBash and Unix-like terminals. This check does not work on PowerShell.

Furthermore, poetry installation fails due to a ModuleNotFoundError:

AC:

• Update the conditional to check if poetry is already installed to be successful on PowerShell
• Fix the ModuleNotFoundError (full error stack attached)

poetry-installer-error-xodgg7gb.log

if [[ $(command -v poetry) ]]; then

The above conditional to check if poetry is installed to the user's path in the shell script, setup.sh only works for GitBash and Unix-like terminals. This check does not work on CMD.

AC:

• Update the conditional to check if poetry is already installed to be successful on CMD

A boilerplate tox setup to run the test suite using pytest and coverage is needed.
This should also be hooked to pre-commit to run during the push stage.

The tox environment should:

• Install all test dependencies:
  • pytest
  • coverage
  • lizard: or should lizard be a separate linting hook to be run during each commit?
• Run test test suite and fail on coverage less than 90%

AC:

• tox is added to setup.sh to be installed as a dev dependency
• tox is setup to run tests using pytest and coverage
  • coverage less than 90% should cause the tests to fail
• A boilerplate test dir is added
  • logger tests?