Coder Social home page Coder Social logo

mtmex3's People

Contributors

gur111 avatar danibondar avatar

Watchers

James Cloos avatar  avatar  avatar Noam avatar  avatar

mtmex3's Issues

Fix magic numebrs

There are lots of magic numbers.
For example, in sniper the movement distance is a magic number. It should be a constant member.
You can define it as hardcoded 4 in the constructor but not in the code. Something like this would be fine imo.

Sniper::Sniper(...): speed(4){}

It's in other places too. Please check.

Move is implemented 3 times

The move shouldn't be implemented 3 times.
Should be implemented once in the character and speed should be a member of character so move can use it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.