guotsuan / awesome-revelation Goto Github PK

Hello,

Thanks for sharing this awesome tool :)

awesome v4.3-1647-ge6f5c7980-dirty (Too long)
 • Compiled against Lua 5.1.4 (running with LuaJIT 2.1.1702233742)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: yes
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: 0.9.2
 • Transparency enabled: yes
 • Custom search paths: no

I'd like to use curr_tag_only and show minimized clients on the current tag. Default behavior only includes clients that are visible. I was able to include minimized clients by changing line 188:

From: match_clients(rule, awful.client.visible(scr), t[scr], is_excluded)
To: match_clients(rule, mouse.screen.selected_tag:clients(), t[scr], is_excluded)

I'm not sure mouse.screen.selected_tag:clients() is the best approach here, but it seems to work, mostly.

Issue:

When using 2 displays, clients that are minimized are not restored properly, ie, the client remains visible even when not selected. When using a single display everything works as expected.

I ran into #29 myself, the recommend fix, t[scr]:delete() works for the bug described in #29, but has no effect on this issue.

I've spent the good part of a day trying to figure this one out, pretty stumped at this point. If anyone has any ideas I am all ears!

Thanks for your time.

EDIT:

I may have figured it out. Trying to fix a hintbox bug. I'll close and post the solution when I know it works reliably.

Is it possible to bring all clients to current tag? I've already disabled zoom option and I wonder whether it is possible to disable additional tag ('Revision') which is created every time.

When I put

local revelation = require("revelation")
local gears     = require("gears")
local awful     = require("awful")
awful.rules     = require("awful.rules")
                  require("awful.autofocus")
local wibox     = require("wibox")
local beautiful = require("beautiful")
local naughty   = require("naughty")
local drop      = require("scratchdrop")
local lain      = require("lain")
beautiful.init(os.getenv("HOME") .. "/.config/awesome/themes/powerarrow-darker/theme.lua")
revelation.init()

so the require at the top and revelation init after beautiful init, I get an error on this line (44 in init.lua):

if type(awful.client.object.toggle_tag) == 'function' then

(Can't access object it is Nil).
When I comment out the the if and the first branch it works.
Version is 3.5.6 and lua.rc is based on copycat powerarrow-darker.

W: awesome: a_glib_poll:239: Last main loop iteration took 0.548 this warning to that value.
W: awesome: luaA_dofunction:78: error while running function
stack traceback:
/home/foo/.config/awesome/revelation/init.lua:166: in function </home/foo/.config/awesome/revelation/init.lua:124>
(tail call): ?
/usr/share/awesome/lib/awful/key.lua:42: in function </usr/share/awesome/lib/awful/key.lua:42>
error: /home/foo/.config/awesome/revelation/init.lua:166: attempt to index field '?' (a nil value)

Any ideas?

Init is never run in the source or specified to be run in the configuration portion of the readme.me for either beautiful or revelation.

This version will crash without running init. This I'm not sure how this extension would ever work without that step unless I'm missing something huge.

In case of errors (e.g. #4), awesome-revelation does not restore the clients when it aborts, which results in a messed up state.

I think this could be fixed by wrapping the functionality, e.g. by using pcall and call the restore function always.

When I use the only-this-tag option for revelation, it is confusing that it changes the layout to a different one containing the exact same clients. This goes against the principle of least surprise. I suggest to make it fall back to hints-only behavior when called for only the current tag.

Hi, thank you for this awesome plugin to awesome wm 🚀

Steps to reproduce:

1. Have multiple screens (each with its tags)
2. Call revelation
3. Choose one client
4. Weird behavior: all clients are attached to all tags.

Hi, I just cloned the project and found it great.

The only thing that bothered me was the fact that after choosing a client, the just created "Revelation" tag persisted on my wibox, which is somehow 'pollutant'. So I adapted it to delete this tag after choosing the client.

It should be important to be added to the project ?

Zooming appears to be possible with the mouse only.

It would be nice to have this available via keyboard, too.

You can use the following code in the keygrabber to detect if Shift is pressed:

awful.util.table.hasitem(mod, "Shift")

I'm using the master branch of Awesome and clients in a floating tag retain their positions from the Revelation view after either selecting a window or cancelling. Tiled clients and floating clients within tiled tags are correctly restored to their original positions.

Hey,

revelation is not working for me.
When calling revelation I get an error and nothing happens:

W: awesome: luaA_dofunction:78: error while running function
stack traceback:
    /home/max/.config/awesome/revelation/init.lua:230: in function 'revelation.restore'
    /home/max/.config/awesome/revelation/init.lua:193: in function 'revelation.expose'
    (...tail calls...)
    /usr/share/awesome/lib/awful/key.lua:42: in function </usr/share/awesome/lib/awful/key.lua:42>
error: /home/max/.config/awesome/revelation/init.lua:230: attempt to index a nil value (field '?')

I've not investigated, but with awesome master I am seeing empty (grey) letterboxes, where the actual letters are missing.

Please let me know in case you cannot reproduce it, and I'll check further.

When in the revelation view, clicking on a client/window does not take you to it's tag, instead it merely exits the revelation view.

Trying upgrade to the new version I got the error: ./revelation/init.lua:31: module 'gears.timer' not found .
I have awesome v3.5.6 (Lua 5.3) running on Arch Linux.

After running revelation ( 2014-02-19) in Awesome v3.5.5 the windows are not restored to the original size and location. The same issue happens when selecting a window and when pressing escape.

the postion if hintbox box ...
wxg4net@02deef5

Calling revelation triggers the resize event for clients, which makes e.g. Vim change its internal window layout (splits): because there is less space for the whole Vim window, the internal windows/splits get shrunken.
After picking a window via revelation, the original (internal) window/split layout isn't restored.

This affects any application which adjusts it's inner layout when being resized to something smaller, but does not restore it when it gets resized back to the original size.

It would be nice, if this could be avoided.

Hi,

Revelation isn't working with upstream awesome. The error message is:

Oops!, something is wrong in revelation.expose_callback!
.config/awesome/awesome-revelation/init.lua:250: attempt to index a nil value (field '?')

I'm using awesome v4.1-207-g24edeac4 (Technologic) (upstream from git).
Revelation is also from git upstream.

sorry, just config wrong ...

The two lines below are missing in revelation.init:

    revelation.fg = args.fg or revelation.fg
    revelation.bg = args.bg or revelation.bg

In awesome v4.3, after using revelation (after selecting a client from it or escaping from it to cancel), running awful.tag.history.restore (Mod + Esc) will attempt to view only the revelation tag and will thus hide all tags. Tapping Mod + Esc again from this position will do nothing, and one must return to a tag via other means.

I think the behavior of awful.tag.history.restore immediately after exiting the revelation tag should be, if possible, to restore the tag that awful.tag.history.restore would have restored before revelation was run. If that's easier said than done, then awful.tag.history.restore should simply do nothing, rather than awkwardly rendering itself useless.

Totally open and grateful for a hack or workaround, either on the revelation side or some sort of wrap-around function for awful.tag.history.restore. Best regards

EDIT: This at least prevents me from accidentally hiding my tags as I use awful.tag.history.restore a lot without thinking (often just tapping it twice quickly is second nature):

    awful.key({ modkey, }, "Escape", function () 
            if tag_history_blocked == nil then awful.tag.history.restore() end 
    end, {description = "go back", group = "tag"}),

...

tag.connect_signal("property::selected", function(t) if t.name == revelation.tag_name then tag_history_blocked = true elseif not t.selected then tag_history_blocked = nil end end)