gunoh / intellicollab Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 77.4 MB

Java 98.00% Kotlin 2.00%

intellicollab's People

Stargazers

Watchers

intellicollab's Issues

Make plugin settings work with IntelliJ 16 EAP

The settings section of the plugin doesn't seem to be available in IntelliJ 16 EAP (144.2925.2):

Add support for Jira issue links

Add support for Collaborator 9.3

9300 branch locks up IDE when using wrong password

When trying to use an incorrect username/password combination on the 9300 branch, a prompt in the console show up to input the correct password via stdin. Meanwhile, the IDE itself is unusable because of the modal login dialog.

There should be no prompt in the console; the IDE should show a balloon with the error message, and the option for the user to open the plugin settings.

Allow uploading of local Git changes

It should be possible to upload local changes when using Git.
The current behavior is that changes that are unstaged are not uploaded. The diffs of the latest commit are uploaded instead when a file has local changes that aren't staged. This is quite inconvenient as IntelliJ does not support the staging area.

Use PasswordSafe to store password

NPE when adding files to review using 'Find action' dialogue

When using the 'Find action' feature (ctrl+shift+a) to add files to an existing review, a NullPointerException occurs:

java.lang.NullPointerException
            at java.util.Objects.requireNonNull(Objects.java:203)
            at java.util.Arrays$ArrayList.<init>(Arrays.java:3813)
            at java.util.Arrays.asList(Arrays.java:3800)
            at com.intellij.openapi.vcs.changes.ChangeListManagerImpl.getChangeListNameIfOnlyOne(ChangeListManagerImpl.java:1089)
            at com.intellij.openapi.vcs.changes.ChangesUtil.getChangeListIfOnlyOne(ChangesUtil.java:196)
            at nl.guno.collab.intellij.AddControlledFileAction.update(AddControlledFileAction.java:240)
            at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareUpdate(ActionUtil.java:136)
            at com.intellij.ide.util.gotoByName.GotoActionModel.updateActionBeforeShow(GotoActionModel.java:302)
            at com.intellij.ide.util.gotoByName.GotoActionModel$ActionWrapper.lambda$getPresentation$0(GotoActionModel.java:626)
            at com.intellij.ide.util.gotoByName.GotoActionModel.lambda$updateOnEdt$4(GotoActionModel.java:443)
            at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
            at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:447)
            at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:431)
            at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:415)
            at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
            at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
            at java.awt.EventQueue.access$500(EventQueue.java:98)
            at java.awt.EventQueue$3.run(EventQueue.java:715)
            at java.awt.EventQueue$3.run(EventQueue.java:709)
            at java.security.AccessController.doPrivileged(Native Method)
            at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
            at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
            at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:781)
            at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:722)
            at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:382)
            at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
            at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
            at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
            at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
            at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
            at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Uploading files to review in (EAP) IntelliJ IDEA 142.5239.7 / intelliccollab 0.22

Argument for @NotNull parameter 'text' of com/intellij/openapi/wm/impl/ToolWindowManagerImpl.notifyByBalloon must not be null
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'text' of com/intellij/openapi/wm/impl/ToolWindowManagerImpl.notifyByBalloon must not be null
at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.notifyByBalloon(ToolWindowManagerImpl.java)
at nl.guno.ccollab.intellij.ui.Notification.showBalloon(Notification.java:47)
at nl.guno.ccollab.intellij.AddToReviewTask.onSuccess(AddToReviewTask.java:149)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$1$2.run(ProgressManagerImpl.java:153)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.a(LaterInvocator.java:337)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:321)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
at java.awt.EventQueue.access$200(EventQueue.java:103)
at java.awt.EventQueue$3.run(EventQueue.java:694)
at java.awt.EventQueue$3.run(EventQueue.java:692)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
at com.intellij.ide.IdeEventQueue.f(IdeEventQueue.java:861)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:649)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:380)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

Prepopulate new review name with active changeset name

IDE blocks when code coll. username/password combination is incorrect

[DESCRIPTION]
When your code coll. username/password combination is incorrect, the guest-IDE blocks.
In the host-IDE, I get the following prompt:

Collaborator client credentials invalid. Please supply a valid password.

I can then enter a password on stdin. When I enter my correct password in the host-IDE, the guest-IDE continues.

[ANALYSIS]
The call to getServerBuild() seems to cause this problem. Maybe we need to use some other method first to check whether the user's credentials are correct.

LoginTask.run()
-> LoginUtils.login()
-> LogonUtils.establishEngineConnection(IGlobalOptions,ICollabClientInterface)
-> LogonUtils.establishEngineConnection(XmlRpcClientConfig)
-> Engine.getServerBuild()

URL field from settings not properly read

When creating a new review, the value of the URL field in the settings doesn't seem to be used.
Instead, the review is created in the Code Collaborator instance referred to from ~/.smartbear/com.smartbear.ccollab.client.txt

It would be better if the value from the settings was used.

Prepopulate bug number in review if available in changelist name

Fix logging

Update failed error with IDEA 2018.1

When opening the version control tool window, I get the below error.
Might this also be the reason why the 'Add to review' button for changelists has disappeared?

update failed for AnAction(nl.guno.collab.intellij.AddControlledFileAction) with ID=nl.guno.collab.intellij.AddControlledFileFromChangesView: com.intellij.openapi.vcs.changes.ChangesUtil.getChangeListIfOnlyOne(Lcom/intellij/openapi/project/Project;[Lcom/intellij/openapi/vcs/changes/Change;)Lcom/intellij/openapi/vcs/changes/ChangeList;
java.lang.NoSuchMethodError: com.intellij.openapi.vcs.changes.ChangesUtil.getChangeListIfOnlyOne(Lcom/intellij/openapi/project/Project;[Lcom/intellij/openapi/vcs/changes/Change;)Lcom/intellij/openapi/vcs/changes/ChangeList;
	at nl.guno.collab.intellij.AddControlledFileAction.update(AddControlledFileAction.java:240)
	at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareUpdate(ActionUtil.java:136)
	at com.intellij.openapi.actionSystem.impl.Utils.doUpdate(Utils.java:259)
	at com.intellij.openapi.actionSystem.impl.Utils.expandActionGroup(Utils.java:202)
	at com.intellij.openapi.actionSystem.impl.Utils.expandActionGroup(Utils.java:153)
	at com.intellij.openapi.actionSystem.impl.Utils.expandActionGroup(Utils.java:228)
	at com.intellij.openapi.actionSystem.impl.ActionToolbarImpl.updateActionsImpl(ActionToolbarImpl.java:1036)
	at com.intellij.openapi.actionSystem.impl.ActionToolbarImpl.access$000(ActionToolbarImpl.java:52)
	at com.intellij.openapi.actionSystem.impl.ActionToolbarImpl$2.updateActionsImpl(ActionToolbarImpl.java:173)
	at com.intellij.openapi.actionSystem.impl.ToolbarUpdater$MyUpdateRunnable.run(ToolbarUpdater.java:186)
	at com.intellij.util.ui.UIUtil.invokeLaterIfNeeded(UIUtil.java:2846)
	at com.intellij.ide.IdeEventQueue.ifFocusEventsInTheQueue(IdeEventQueue.java:181)
	at com.intellij.ide.IdeEventQueue.executeWhenAllFocusEventsLeftTheQueue(IdeEventQueue.java:140)
	at com.intellij.openapi.wm.impl.FocusManagerImpl.doWhenFocusSettlesDown(FocusManagerImpl.java:190)
	at com.intellij.openapi.actionSystem.impl.ToolbarUpdater.updateActions(ToolbarUpdater.java:108)
	at com.intellij.openapi.actionSystem.impl.ToolbarUpdater.access$400(ToolbarUpdater.java:40)
	at com.intellij.openapi.actionSystem.impl.ToolbarUpdater$MyTimerListener.run(ToolbarUpdater.java:158)
	at com.intellij.openapi.actionSystem.impl.WeakTimerListener.run(WeakTimerListener.java:54)
	at com.intellij.openapi.actionSystem.impl.ActionManagerImpl$MyTimer.runListenerAction(ActionManagerImpl.java:1398)
	at com.intellij.openapi.actionSystem.impl.ActionManagerImpl$MyTimer.notifyListeners(ActionManagerImpl.java:1388)
	at com.intellij.openapi.actionSystem.impl.ActionManagerImpl$MyTimer.actionPerformed(ActionManagerImpl.java:1372)
	at javax.swing.Timer.fireActionPerformed(Timer.java:313)
	at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
	at java.awt.EventQueue.access$500(EventQueue.java:98)
	at java.awt.EventQueue$3.run(EventQueue.java:715)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:837)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:766)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:434)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

IntelliJ IDEA 2018.1 EAP (Ultimate Edition)
Build #IU-181.4096.5, built on March 6, 2018
IntelliJ IDEA EAP User
Expiration date: April 5, 2018
JRE: 1.8.0_152-release-1136-b16 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Use Gradle as build system

Using Gradle as build system allows us to easily build plugins for the IntelliJ Platform on a specific version of the IntelliJ Platform SDK.

http://www.jetbrains.org/intellij/sdk/docs/tutorials/build_system.html

NPE when uploading files to Subversion

v0.20pre:

null
java.lang.NullPointerException
at nl.guno.ccollab.intellij.AddToReviewTask.run(AddToReviewTask.java:102)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$TaskRunnable.run(ProgressManagerImpl.java:621)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$3.run(ProgressManagerImpl.java:194)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.a(ProgressManagerImpl.java:281)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:233)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.runProcess(ProgressManagerImpl.java:181)
at com.intellij.openapi.progress.impl.ProgressManagerImpl$9.run(ProgressManagerImpl.java:530)
at com.intellij.openapi.application.impl.ApplicationImpl$8.run(ApplicationImpl.java:406)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
at org.jetbrains.ide.PooledThreadExecutor$1$1.run(PooledThreadExecutor.java:56)

java.lang.NoClassDefFoundError: javax/xml/ws/http/HTTPException
	at nl.guno.collab.intellij.LoginTask.run(LoginTask.java:64)
	at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:731)
	at com.intellij.openapi.progress.impl.CoreProgressManager$5.run(CoreProgressManager.java:442)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:164)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:586)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:532)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:86)
	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:151)
	at com.intellij.openapi.application.impl.ApplicationImpl.lambda$null$13(ApplicationImpl.java:611)
	at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:321)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException PluginClassLoader[IntelliCollab, 2.1] com.intellij.ide.plugins.cl.PluginClassLoader@1cb39117
	at com.intellij.ide.plugins.cl.PluginClassLoader.loadClass(PluginClassLoader.java:51)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	... 15 more

gunoh / intellicollab Goto Github PK

intellicollab's People

Stargazers

Watchers

intellicollab's Issues

Recommend Projects

Recommend Topics

Recommend Org