guldoman / mpv_inhibit_gnome Goto Github PK

flatpak mpv
fedora kde 5.25
log:

dbus[2]: arguments to dbus_message_unref() were incorrect, assertion "message != NULL" failed in file ../../dbus/dbus-message.c line 1727.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace

The update removed the gnome.SessionManager override entry. But applying the override again, didn't fix the screen go blank.
Besides that, nothing has changes in my setup.

Am using flatpak override --user --talk-name=org.gnome.SessionManager io.mpv.Mpv

Hi @Guldoman,
I like the album art check. But I do get the motivation why you used bitfields (does not seem necessary).
However, maybe we should avoid passing NULL to strcmp here

See here:
https://stackoverflow.com/questions/21865041/in-c-what-exactly-happens-when-you-pass-a-null-pointer-to-strcmp

Additional confusion:
Why do we even need {NULL , MPV_FORMAT_NONE }?
Do we really need to check value = data > 0 why not leave it at value = data != 0?

bool value = *(int64_t *)prop->data > 0;

Looks like this is no longer needed as of GNOME 45 and later, and least on Wayland.
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3145

README.md should probably be updated to reflect this.

I installed this using AUR and it has been working well. But sadly, sleeping was not the only problem I am having with MPV on Wayland Gnome. Since this plug-in already deals with Wayland Gnome, I wonder if you could add more fixes for other problems on Wayland Gnome, to make this plugin more like a one-stop "Wayland Gnome fix". If that does not fit the purpose of this plug-in, then maybe as separate plug-ins.

For example, "stay on top (shift +T)" does not work. I have to press alt+space and click "Always on Top" each time, and it has been a pain in the lower back.

Also, it does not work to drag-and-drop a video file on a Samba network share from Gnome Files (nautilus) to MPV. If I know it correctly, Gnome maps network Samba file (e.g., smb://server/file.mkv) into a local virtual file (e.g., /run/user/1000/gvfs/smb-share:server=server,share=file.mkv) using GVFS, but Gnome Files passes the raw Samba address when drag-and-dropping and MPV developers seem to have no intention to support GVFS. If a plug-in could convert that Samba address into its locally mapped GVFS path, and tell MPV to play that local file path, MPV will be able to play it.