guijan / libobsd Goto Github PK

I should switch to https://github.com/termux/termux-docker/ which is maintained

• Windows 10
• GCC 11.2.0 installed via scoop
• PowerShell

Minimal (?) reproduction:

subprojects/libobsd.wrap:

[wrap-git]
url = https://github.com/guijan/libobsd.git
revision = 9942023632f9c5a5b32db61cee6d37e996e0b1dd
depth = 1

[provide]
libbsd-overlay = libobsd_dep
libobsd = libobsd_dep

meson.build:

project('libobsd-test', ['cpp'])
libbsd_dep = dependency('libbsd-overlay')
test_src = files('main.cpp')
e = executable(
  'my-test',
  [test_src],
  dependencies : [libbsd_dep],
  install: false,
)    
test('my-test', e)

main.cpp:

#include <string.h>

main(void)
{
	char buf[16];
	strlcat(buf, "another test string", sizeof(buf));
}

Output

PS C:\Users\i1B583116\src\libobsd-test> meson test -C .\builddir\ --suite 'libobsd-test'
ninja: Entering directory `C:\Users\i1B583116\src\libobsd-test\builddir'
[2/2] Linking target my-test.exe
FAILED: my-test.exe
"g++"  -o my-test.exe my-test.exe.p/main.cpp.obj "-Wl,--allow-shlib-undefined" "-Wl,--start-group" "subprojects\libobsd\libobsd.a" "-lbcrypt" "-lbcrypt" "-Wl,--subsystem,console" "-lkernel32" "-luser32" "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" "-lcomdlg32" "-ladvapi32" "-Wl,--end-group"
c:/users/_/scoop/apps/gcc/11.2.0/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: my-test.exe.p/main.cpp.obj:C:\Users\_\src\libobsd-test\builddir/../main.cpp:6: undefined reference to `__imp_strlcat'
collect2.exe: error: ld returned 1 exit status

The libobsd test builds also fail if --suite is not specified.

I believe this has something to do with the -DOBSD_IMPORTING flag and the resulting dllimport lines. When I prevent it from being added the build succeeds.

compiling libtirpc with musl (which has no sys/queue.h) errors with:

../src/clnt_bcast.c:43:10: fatal error: sys/queue.h: No such file or directory
   43 | #include <sys/queue.h>

I need to investigate a better setproctitle() implementation for Linux.

According to the prctl() man page: https://man7.org/linux/man-pages/man2/prctl.2.html
Linux 3.5's prctl() has PR_SET_MM_ARG_START and PR_SET_MM_ARG_END which "Set the address above/below which the program command line is placed." This should allow me to change the program title much more easily.

I falsely believed it was possible to hide symbols on Unix when statically linking, so the library was developed with this incorrect belief. Private symbols should be qualified with something to reduce the likelihood of clashes with whatever users have, and so I can blame the other party in case they use those symbols and complain their behaviors change.

I made the libobsd copy of OpenBSD's getopt() include an optreset variable, but not the OpenBSD getopt() implementation if it detects the system has a getopt(). This might make some programs work just fine, but it's best to include the whole implementation in this case to make all programs work as they should.

Sometimes, the Windows CI fails. This seems to only affect MSYS2 environments and a retry usually works. I need to investigate what is the source of these failures.

I can't reproduce the issue on real hardware, and there is no diagnostic output in the CI. This bug is very hard to fix.

I incorrectly believed it defaulted to the project version.