guhelski / forecast-php Goto Github PK

The encoding for the – character is displaying as –. For example, if we are expecting snow the forecast says, "Snow (1–2 in.) throughout the day." Is the data encoded as UTF-8?

To help with composer management on sites that use this. Tag - Packagist release would be really helpful.

The code that composes a request uses string concatenation to interpolate latitude and longitude into a URL. This triggers a conversion to string, which, for numeric values, uses the current locale. If the locale is something like nl_NL, which uses ',' as the decimal separator rather than '.', then so will the resulting URL. The Forecast API, however, expect the dot character, always, so this produces an error.

On a side note, there is also a security implication here; I'll be happy to explain in private if you prefer.