guardianlabs / guardian-keyper Goto Github PK

steps:

1. create new vault, (flag "keep one shard on my device" is on)
2. add 2 guardians
3. split secret
4. as owner, open "shards" tab

actual result:
shard not showing up on owner device

expected result:
shard showing up on owner device
also, other guardians can scan his code to restore vault

The instructions for restoring a vault are unclear and should be broken down into clear, step-by-step instructions.

https://github.com/marketplace/actions/cla-assistant-lite

• [] check how the resulting DX works
• [] hire a lawyer to check the stuff for correctness.

• [] Add proper examples, remove TBDs, etc

• Implement CLA assistant
• Add Amplitude Analytics
• Make Amplitude and Sentry dependencies optional (e.g. through compile-time defines)
• Add "Vaults" (multiple secrets per group) feature
• Add ability to restore ownership to a guardian device
• Internationalization
• Remove tags in favour of guardians renaming
• Add pure QR-based data exchange
• Add automated unit and integration tests
• Implement compatibility (e.g. guardians serving) with the upcoming KeyperPro
• Move to LedgerZero for data transfer and storage backend

Adding a Guardian through a text code containing "This is a SINGLE-USE..." does not work.

Apparently, Finish AddSecret event is only logged on flow an error (_showRejected):

Instead, it should be triggered on _showSuccess:

Guardians should be clearly instructed that they need to have the app open and be online to accept or deliver a shard when requested.

Sentry Issue: KEYPERFREE-C

OSError: OS Error: No route to host, errno = 65
SocketException: SocketException: Send failed (OS Error: No route to host, errno = 65), address = ::, port = 2022
  File "transport_udp.dart", line 56, in TransportUdp.send
  File "router_base.dart", line 98, in RouterBase.sendDatagram
  File "router_l1.dart", line 133, in RouterL1.sendMessage

Even with the "Use proxy" flag disabled, requests for Guardians are still being routed through the proxy. The flag disabling only takes effect after restarting the application.

Assistance codes (QR or text) are not recognized when restoring Vault. After entering the code and pressing Confirm, the application hangs on the code input selection screen.

The "Become a Guardian" feature is prominently displayed but might be more logically placed at the end of the flow. Users primarily want to save their secret and invite Guardians. The suggested order is: "Create a Vault", "Recruit Guardians", and then optionally "Become a Guardian".

Randomly assigned emojis might not be to every user's liking.

The validation for a minimum of 3 characters when entering the device name for the first time is not functioning.

The current onboarding flow might be unclear for first-time users. One idea is to send guardians an invitation to download the app along with instructions on generating and sending back a code.

To better explain the app's functionality, consider adding a video explaining the flow directly in the market after the screenshots.

The option to add a guardian through a text code can be confusing, especially when the button is inactive due to a lack of copied text. Furthermore, the necessity to copy the text isn't explicitly mentioned.

Some requests to add Guardian are automatically marked as Rejected without displaying the Approve|Rejected window. This issue can be resolved temporarily by restarting the application on the owner's device.

Users should have the ability to rename their vault.

Sentry Issue: KEYPERFREE-H

NsdError: NsdError (message: "stopDiscovery: MulticastLock under-locked nsdMulticastLock", cause: internalError)
  File "method_channel_nsd_platform.dart", line 203, in MethodChannelNsdPlatform.invoke.<fn>
...
(2 additional frame(s) were not displayed)

android studio 2022.2.1

steps:

1. open app (wi-fi connected)
2. create a vault
3. turn off wi-fi, 4g connection is on
4. scan guardian QR-code

actual result:
as guardian, doesnt get incoming request
as owner, to send a request after changing network, need to restart app

expected result:
as guardian, receives incoming request
as owner, no reboot required when changing network type